Conversation
|
env_iter_intel_RH2.sh |
|
Hi @jorekart, I uploaded the file for you as env_iter_intel_RH_2026.sh. Is this compatible with the old version or will it break runs? |
|
@jorekart , could you double check the modules you are loading? it does not find matplotlib If you find a fix, you can update the environment (env_iter_intel_RH_2026.sh) with your username and password yourself |
|
@N-Schwarz @matthiashoelzl |
| parser.add_argument("-t", "--time", type=float, default=-1, help="The requested time in seconds") | ||
| args = parser.parse_args() | ||
|
|
||
| entry_options = {} if args.dd_version is None else {"dd_version": args.dd_version} |
There was a problem hiding this comment.
Would you not get the same result if you do entry_options = {"autoconvert": False} if ...?
| entry_description = "legacy entry: user=%s, database=%s, pulse=%s, run=%s" % ( | ||
| args.user, args.database, args.pulse, args.run) | ||
|
|
||
| atexit.register(lambda: entry.close()) |
There was a problem hiding this comment.
Is this necessary? Wouldn't it make more sense to put it after the next if because you might close and reopen it?
| type(ids_pf_active) :: pf_active | ||
| type(ids_disruption) :: disruption_ids | ||
| type(ids_spi) :: spi_ids | ||
| type(ids_plasma_transport), target :: transport_ids |
There was a problem hiding this comment.
why does only this have a target?
| ! --- Fill global quantities (call mod_integrals3D) | ||
| equilibrium_ids%time_slice(i_slice)%global_quantities%psi_axis = ES%Psi_axis * fact_psi | ||
| equilibrium_ids%time_slice(i_slice)%global_quantities%psi_boundary = ES%Psi_bnd * fact_psi | ||
| equilibrium_ids%time_slice(i_slice)%global_quantities%psi_magnetic_axis = ES%Psi_axis * fact_psi |
There was a problem hiding this comment.
Is the boundary one no longer required?
|
|
||
| ! --- Optional disruption metadata. Leave these nodes empty unless the | ||
| ! corresponding values were explicitly provided in imas.nml. | ||
| if (summary_disruption_type /= -999) then |
There was a problem hiding this comment.
Is this also in the disruption ids?
matthiashoelzl
left a comment
matthiashoelzl
left a comment
There was a problem hiding this comment.
This looks good to me, but without running tests myself. Based on the automatic tests passing and you having tested yourself, I approve.
This branch has not been deployed
3 participants
This PR implements the following