Skip to content

Use positive face-normal projection for fcQgam #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlore wants to merge 7 commits into
base: feature/wg-release
Choose a base branch
from
Open

Use positive face-normal projection for fcQgam #39

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9d68a3d
Use positive face-normal projection for fcQgam
jlore Aug 10, 2026
886c5d4
Merge branch 'feature/wg-release' into feature/wg-release-fcqgam
hrdoktorx Aug 13, 2026
fdb40ce
Merge branch 'feature/wg-release' into feature/wg-release-fcqgam
hrdoktorx Aug 19, 2026
b1218b4
Merge branch 'feature/wg-release' into feature/wg-release-fcqgam
hrdoktorx Sep 8, 2026
84344b0
Merge branch 'feature/wg-release' into feature/wg-release-fcqgam
hrdoktorx Sep 13, 2026
e6385c1
Merge branch 'feature/wg-release' into feature/wg-release-fcqgam
hrdoktorx Sep 14, 2026
d349181
Merge branch 'feature/wg-release' into feature/wg-release-fcqgam
hrdoktorx Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/preprocessing/b2agmt.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,10 +529,10 @@ subroutine b2agmt (g, m, isymm, artificial_slab)
! With this method, numerical error on the 5-point contribution on
! gradient calculation is significantly reduced for general grids

fcQgam1(iFc,0) = sinang(ec1fc(0),ec1fc(1),fn(0),fn(1))
fcQgam1(iFc,0) = abs(sinang(ec1fc(0),ec1fc(1),fn(0),fn(1)))
fcQgam1(iFc,1) = cosang(ec1fc(0),ec1fc(1),fn(0),fn(1))

fcQgam2(iFc,0) = sinang(efcc2(0),efcc2(1),fn(0),fn(1))
fcQgam2(iFc,0) = abs(sinang(efcc2(0),efcc2(1),fn(0),fn(1)))
fcQgam2(iFc,1) = cosang(efcc2(0),efcc2(1),fn(0),fn(1))

g%fcQgam(iFc,0) = ( fcQgam1(iFc,0)*g%fcHc(iFc,1) +
Expand Down