feat: add request timing to Response#126
Merged
privateip merged 1 commit intoitential:mainfrom Mar 20, 2026
Merged
Conversation
Member
privateip
commented
Mar 20, 2026
privateip
commented
- Add started_at and finished_at ISO 8601 UTC timestamps to Response, captured around client.send() in both Connection and AsyncConnection
- Add elapsed_ms property to Response that computes duration in whole milliseconds (truncated)
- Extend Response.init to require started_at and finished_at as keyword-only arguments
- Update all direct Response constructions in tests to pass timing constants
- Add dedicated timing tests covering properties, elapsed_ms accuracy, truncation, and all HTTP methods
- Add started_at and finished_at ISO 8601 UTC timestamps to Response, captured around client.send() in both Connection and AsyncConnection - Add elapsed_ms property to Response that computes duration in whole milliseconds (truncated) - Extend Response.__init__ to require started_at and finished_at as keyword-only arguments - Update all direct Response constructions in tests to pass timing constants - Add dedicated timing tests covering properties, elapsed_ms accuracy, truncation, and all HTTP methods
privateip
force-pushed
the
http-request-timing
branch
from
9430eff to
8e0260d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.