chore: fix all mypy errors and add typecheck to CI#119
Merged
privateip merged 1 commit intoitential:develfrom Mar 18, 2026
Merged
chore: fix all mypy errors and add typecheck to CI#119privateip merged 1 commit intoitential:develfrom
privateip merged 1 commit intoitential:develfrom
Conversation
Member
privateip
commented
Mar 18, 2026
privateip
commented
- Refactor logging.py to define TRACE/FATAL/NONE as module-level constants before assigning to the stdlib logging module, reducing type: ignore comments from 12 to 3 targeted suppressions
- Fix Callable annotation bug in heuristics.py add_pattern (missing return type) and extract _make_redaction_func helper to give mypy an inferable typed closure
- Add None guard before add_pattern call and assert on _default_redactions to resolve union-attr and arg-type errors in heuristics.py
- Suppress http.py try/except HTTPMethod import conflict with targeted attr-defined and no-redef ignores
- Add type: ignore[misc] to TYPE_CHECKING class definitions in platform.py and gateway.py where MRO causes attribute type conflicts
- Add make typecheck target and wire it into make ci and the quality job in ci.yaml so static analysis runs on every PR
- Refactor logging.py to define TRACE/FATAL/NONE as module-level constants before assigning to the stdlib logging module, reducing type: ignore comments from 12 to 3 targeted suppressions - Fix Callable annotation bug in heuristics.py add_pattern (missing return type) and extract _make_redaction_func helper to give mypy an inferable typed closure - Add None guard before add_pattern call and assert on _default_redactions to resolve union-attr and arg-type errors in heuristics.py - Suppress http.py try/except HTTPMethod import conflict with targeted attr-defined and no-redef ignores - Add type: ignore[misc] to TYPE_CHECKING class definitions in platform.py and gateway.py where MRO causes attribute type conflicts - Add make typecheck target and wire it into make ci and the quality job in ci.yaml so static analysis runs on every PR
privateip
force-pushed
the
chore/support-typechecking
branch
from
05b76b9 to
2833ab7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.