fix: version should match app's release version#48
Open
holysoles wants to merge 1 commit intoish-app:masterfrom
Open
fix: version should match app's release version#48holysoles wants to merge 1 commit intoish-app:masterfrom
holysoles wants to merge 1 commit intoish-app:masterfrom
Conversation
✅ Deploy Preview for ish ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another attempt of addressing the issue that #46 tried to resolve.
Problem
Currently, the ish.app AltStore source is incompatible with AltStore 2.0 and SideStore (ish-app/ish#2563). The previous attempt of trying to solve this on the ish.app project (#46) was hardcoding the version number, which was an area of feedback that couldn't be addressed, since a given GitHub release provides no indication of the app version that the build is for.
Solution
I've opened a PR on the ish project (ish-app/ish#2658) that will name each nightly GitHub release in semver formatting:
<version number>-build<build number>.With that change, we can then parse this information in the JSON template here to properly provide both the app version and build number to the appropriate AltStore Source fields. I've opened a PR for that change on the ish.app repo: