Repository navigation
fix: unescape adjacent bracket escapes - #341
Open
parijat1222q wants to merge 1 commit into
Open
parijat1222q wants to merge 1 commit into
parijat1222q wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #340.
The default-mode bracket pass consumes the character before a bracket escape. Adjacent escapes therefore only decode every other one:
unescape('[a][b]')returns'a[b]'instead of'ab'.Match and retain backslash-escaped characters in that pass rather than consuming a prefix before each bracket. This also lets a bracket escape after a paired backslash be decoded. Keep the following backslash pass and Windows-only behavior unchanged.
Tests cover adjacent bracket escapes, bracket-escaped
escape()round trips, odd/even backslashes, bothmagicalBracessettings, Windows-only mode, and slash exclusions.Validation on Linux/Node22.23.3:
npm test -- -c -t0:7068 assertions pass,36 test files, zero failures.npm run prepare,npx oxlint src test, Prettier check on changed files, andgit diff --checkpass.Other operating systems and Node versions have not been run locally.