-
Notifications
You must be signed in to change notification settings - Fork 3.6k
General Visualizer Fixes #5935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
General Visualizer Fixes #5935
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2a87bfa
init fixes
matthewtrepte 21d51fb
more fixes
matthewtrepte 33a1774
revert visualizer cfg
matthewtrepte 1012ea1
address reviewbot;
matthewtrepte 749f0d0
lint
matthewtrepte 5eb0caf
more fixes
matthewtrepte 7e86c65
clean up PR
matthewtrepte 6738fb5
tweak docs
matthewtrepte 2b7366d
fix CI
matthewtrepte fe15dd6
fix table
matthewtrepte 6b442af
fix other doc issues
matthewtrepte 79c98a8
PR feedback
matthewtrepte 3246c9c
update comment
matthewtrepte b470716
fix license check
matthewtrepte 243f43a
nits
matthewtrepte e1ff279
merge
matthewtrepte bdc1e62
Merge branch 'develop' into mtrepte/debug
matthewtrepte e88eb84
fix test
matthewtrepte 2988b5b
remove duplicate link which causes CI failures
matthewtrepte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Clarified ``--video`` behavior when multiple video-capable visualizers are active: | ||
| Gymnasium video recording captures one ``env.render()`` stream, with Kit taking | ||
| priority over Newton. |
6 changes: 6 additions & 0 deletions
6
source/isaaclab/changelog.d/clarify-visualizer-camera-sensor-mode.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Improved visualizer tiled-camera errors when ``tiled_cam_prim_path`` is set but | ||
| the scene has no Isaac Lab ``Camera`` sensors, and clarified the camera-mode | ||
| documentation for Cartpole camera tasks. |
6 changes: 6 additions & 0 deletions
6
source/isaaclab/changelog.d/fix-scene-data-articulation-transforms.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added a scene-data backend hook for active ``InteractiveScene`` access so | ||
| backends can source scene-owned entity transforms without relying on global | ||
| rigid-body views, and visualizers can discover scene-owned contact sensors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
source/isaaclab_newton/changelog.d/expose-newton-contact-buffer.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added a ``NewtonManager.get_contacts()`` accessor so visualizers can render | ||
| Newton contact buffers without reaching into manager internals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
source/isaaclab_physx/changelog.d/reduce-ant-joint-wrench-warnings.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Fixed excessive PhysX tensor warnings from Ant tasks with ``JointWrenchSensor`` | ||
| by sourcing scene-data transforms for articulation links from Isaac Lab | ||
| articulation views instead of a global PhysX rigid-body view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
source/isaaclab_visualizers/changelog.d/fix-newton-contact-visualization.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Fixed Newton visualizer contact rendering by logging Newton contact buffers | ||
| when available and falling back to scene contact sensors for PhysX-backed | ||
| scenes. |
15 changes: 15 additions & 0 deletions
15
source/isaaclab_visualizers/changelog.d/fix-newton-hud-imgui-dependency.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Fixed Newton visualizer HUD dependency checks by requiring | ||
| ``typing-extensions>=4.15.0`` for the Newton visualizer extra and failing | ||
| integration tests when Newton reports that ``imgui_bundle`` could not be | ||
| imported. Removed the legacy ``setup.py`` for ``isaaclab_visualizers`` now that | ||
| ``pyproject.toml`` carries the package metadata. | ||
|
|
||
| * Fixed Rerun and Viser visualizers rendering Newton infinite ground planes too | ||
| small by expanding non-positive plane extents to the same large finite size | ||
| used by Newton GL. | ||
|
|
||
| * Fixed Viser visualizer ground-grid flickering by reusing unchanged plane grid | ||
| line segments instead of removing and re-adding them every frame. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.