Repository navigation
Conversation
sairex53
requested review from
brendangregg,
chenhengqi,
ekyooo and
yonghong-song
as code owners
October 23, 2026 10:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context::add_probe()currently scans every previously collected probe to merge locations with the same provider and name. On binaries with many USDT entries, this makes context creation quadratic.Keep the ordered probe vector for iteration and add a provider/name index for average constant-time lookup. Repeated entries reuse the indexed probe and append their location. The regression test verifies that duplicate entries are merged into one probe with two locations.
Fixes #5161.
Testing:
cmake --build /tmp/bcc-5161-build --target test_libbcc -j1— passed../test_libbcc "test finding a probe in our own process"— all 10 assertions passed; the process then aborts during LLVMTensorSpecstatic teardown. This also occurs with--list-tests, before any test runs.git show --check HEAD— passed.