Feat: New TfComponents package to export RoleMap, Capability and TimeLock from product_core#89
Merged
chrisgitiota merged 29 commits intomainfrom Feb 4, 2026
Merged
Feat: New TfComponents package to export RoleMap, Capability and TimeLock from product_core#89chrisgitiota merged 29 commits intomainfrom
chrisgitiota merged 29 commits intomainfrom
Conversation
…les and some basic tests
…avoid name clashes during development
…shes during development
…y example solution
…to "TfComponents"
itsyaasir
reviewed
Jan 26, 2026
eike-hass
reviewed
Jan 27, 2026
eike-hass
reviewed
Jan 27, 2026
eike-hass
reviewed
Jan 27, 2026
eike-hass
reviewed
Jan 27, 2026
eike-hass
reviewed
Jan 27, 2026
eike-hass
reviewed
Jan 27, 2026
eike-hass
reviewed
Jan 27, 2026
eike-hass
reviewed
Jan 27, 2026
Co-authored-by: Eike Haß <eike-hass@web.de>
itsyaasir
reviewed
Jan 28, 2026
itsyaasir
reviewed
Jan 28, 2026
itsyaasir
reviewed
Jan 28, 2026
Contributor
|
One Small thought: some doc comments repeat what the code already tells us: Similarly, in these comments The function signatures make this clear, and thanks to the field naming you chose, I feel it is self documenting and doesn't require the comments. Comments are a maintenance liability — when code changes, comments must too, or they become misleading. Verbose comments that duplicate the code tend to drift out of sync over time. What's valuable to keep:
Consider trimming:
Just a suggestion, I am happy to discuss! |
itsyaasir
reviewed
Jan 28, 2026
itsyaasir
reviewed
Jan 28, 2026
itsyaasir
reviewed
Jan 28, 2026
itsyaasir
reviewed
Jan 28, 2026
itsyaasir
reviewed
Jan 28, 2026
itsyaasir
reviewed
Jan 28, 2026
…eCapabilities in the Counter example
…the README descriptions
…ormal formated text
Co-authored-by: Yasir <yasirshariffa@gmail.com>
Co-authored-by: Yasir <yasirshariffa@gmail.com>
…to feat/role-map # Conflicts: # components_move/sources/capability.move
…void name clashes
Contributor
Author
|
IMO we should discuss the "doc comments" outside of this PR. Already sent some thoughts on this @itsyaasir. I couldn't resolve the comment BTW. |
itsyaasir
approved these changes
Feb 4, 2026
chrisgitiota
added a commit
to iotaledger/notarization
that referenced
this pull request
Feb 5, 2026
Audit Trail `RoleMap` & `Capability` integration and the Notarization integration for `TimeLock` has been migrated to use `TfComponents` as the following move modules have been moved from the Notarization repository to the new `TfComponents` package in `product_core` : * audit_trail::role_map * audit_trail::capability * notarization::timelock More details can be found in the product-core PR: iotaledger/product-core#89 The Rust and WASM bindings for `TimeLock` are still located in the `notarization` repository. These will be moved to `product-core` during future AT development. Additionally, the Move type `TimeLock` which is now used from `product-core` package `TsComponents` offers new additionally variants `UnlockAtMs` and `Infinite`. The Rust and WASM bindings have been extended accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This PR introduces the new Move package
TfComponentsin product-core. The package is contained in folder "components_move". There will probably also be Rust and TS bindings for these Move modules (see below).As a first step to move the following modules from the Notarization repo to
product-core, the modules have been copied intoTfComponentsand module paths and docs have been migrated accordingly:The Move type
TimeLockoffers new additionally variantsUnlockAtMsandInfinite.Rust and WASM bindings for
TimeLockand newTimeLockvariantsThe Rust and WASM bindings for
TimeLockare still located in thenotarizationrepository. The plan is to move these bindings into newproduct-corepackages:tf_componentscontained in foldercomponents_rustcomponents_wasmcontained in folderbindings/components_wasmThis will be implemented in a future PR.
How the change has been tested
components_movecan be run as usual:iota move testRoleMap&Capabilityintegration and the Notarization integration forTimeLockhas been migrated to useTfComponentsin the feat/audit-trails-dev-product-core-role-map branch. All former existing tests can be run successfully.