Remove @feltjs/eslint-config to fix build#29
Open
Dr-Electron wants to merge 1 commit intoiotaledger:mainfrom
Open
Remove @feltjs/eslint-config to fix build#29Dr-Electron wants to merge 1 commit intoiotaledger:mainfrom
Dr-Electron wants to merge 1 commit intoiotaledger:mainfrom
Conversation
Contributor
Author
|
I just realised that this is probably how you import the feltjs config? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Sems like
@feltjs/eslint-configdoesn't exist anymore. Not sure if it was even used in this Project, I would have expected that you have to import it in some config. So if we never used it, we can just merge this.If we used it, there seems to be a new version by the same maintainer here, but it only works with svelte >=4 and some other changes. But maybe we could just copy the config if we really need it. I will leave that up to you.
Type of change
How the change has been tested
Run locally. Output seems to be the same.
Change checklist