This repository was archived by the owner on Oct 4, 2026. It is now read-only.
Repository navigation
fix(webv2): darken success and warning toast fills for AA contrast - #389
Merged
Merged
Conversation
Chakra's green/orange 600 fills held white toast text at 3.3:1 and 3.6:1; use the 700 step. The toast contrast test now covers all four status types. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lstein
requested review from
JPPhoto,
Pfannkuchensack and
blessedcoolant
as code owners
September 30, 2026 21:56
…colors A fixed 200ms sleep could read an interpolated border color mid-transition on a loaded CI runner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…fix/toast-status-contrast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Success and warning toasts put white text on Chakra's
green.solid/orange.solid(the 600 step): 3.30:1 and 3.56:1, below WCAG AA (4.5:1) for their 14px titles and descriptions — no opacity change can fix that. Toasts now usegreen.700(5.02:1) andorange.700(5.18:1) fills; error and info are unchanged. Builds on #388, which already renders toast descriptions at full opacity.Related Issues / Discussions
Stacked on #388 (base branch
feat/properties-pane-title); retarget tomainonce #388 merges.QA Instructions
Trigger a success toast (e.g. copy/save actions) and a warning toast: fills are a step darker, still clearly green/orange, text fully legible. Verified visually in Chromium by rendering all four toast types.
pnpm check:releasepasses (lint, architecture, unit + browser tests, fixtures, performance budgets, project files, accessibility).ToastContrast.browser.test.tsxnow asserts AA description contrast for error, info, success and warning.Review
No material findings.
Checklist
What's Newcopy (if doing a release after this PR)🤖 Generated with Claude Code