fix(android): allow older Kotlin compilers with ads SDK 25.4 - #866
Open
floze-the-genius wants to merge 1 commit into
Open
fix(android): allow older Kotlin compilers with ads SDK 25.4#866floze-the-genius wants to merge 1 commit into
floze-the-genius wants to merge 1 commit into
Conversation
|
air seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Google Mobile Ads 25.3+ embeds Kotlin 2.3 metadata even though this module only consumes its public Java API. That makes the library fail to compile in Expo and React Native projects still using Kotlin 2.1.x.
Configure only this library's
KotlinCompiletasks to skip the dependency metadata version check. This preserves the AndroidAgeRestrictedTreatmentAPI added with the newer SDK without forcing every consumer module to upgrade to Kotlin 2.3.Related issues
Fixes #863
Release Summary
Allow Android projects using Kotlin 2.1.x to compile with Google Mobile Ads SDK 25.4.0.
Checklist
AndroidiOSe2etests added or updated in__tests__e2e__jesttests added or updated in__tests__Test Plan
play-services-ads:25.4.0AAR classes.-Xskip-metadata-version-checkconfiguration in Groovy.yarn tests:jest --runInBand(7 suites passed, 79 tests passed)yarn tsc:compileyarn lintA full Android example assemble was not run locally because this machine has no accepted Android SDK installation; the repository Android CI remains the end-to-end build check.
🔥