Skip to content

feat(components): allow custom icons on Feedback Label Popup #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mairasalazar wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −1
Open

feat(components): allow custom icons on Feedback Label Popup #345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4d2a68
feat(components): allow override Feedback Label Popup
mairasalazar Aug 28, 2026
0754c8b
refactor: remove overridable
mairasalazar Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/lib/forms/FeedbackLabel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ import { InvenioPopup } from "../elements/accessibility";
import PropTypes from "prop-types";
import { Field } from "formik";

const ORIGIN_ICONS = {
orcha: "fire blue",
};

export class FeedbackLabel extends Component {
getAllErrSubPaths = (obj, prev = "") => {
const result = [];
Expand Down Expand Up @@ -80,7 +84,7 @@ export class FeedbackLabel extends Component {
<InvenioPopup
popupId={`invenio-form-feedback-error-${fieldPath}`}
ariaLabel="Form field feedback error"
trigger={<Icon name={icon} />}
trigger={<Icon name={ORIGIN_ICONS[error.origin] || icon} />}
// Rule descriptions can contain HTML to link to a page with more details about the rule.
// This field is sanitized in the backend with SanitizedHTML.
content={<span dangerouslySetInnerHTML={{ __html: error.description }} />}
Expand Down
Loading