[opentelemetry] Split enable_opentelemetry into enable_metrics and enable_tracing#1504
Open
the-glu wants to merge 3 commits into
Open
[opentelemetry] Split enable_opentelemetry into enable_metrics and enable_tracing#1504the-glu wants to merge 3 commits into
the-glu wants to merge 3 commits into
Conversation
the-glu
force-pushed
the
split_monitoring_flags
branch
from
992f8ce to
94f0397
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follow #1503
It split the
enable_opentelemetryflag into two dedicated sub flags.Preparing deployments files to add DSS metrics, it doesn't make sense to enable full tracing just for 'normal' Prometheus metrics, especially as it show warning if partially configured.
No backward compatibly added, as the flag is very new, needed manual work to be used and only tracing has been released, who shall only be used for debugging.