Fix macOS build: missing MacMSRDriver include path for numa_to_socket_example#1004
Merged
rdementi merged 2 commits intopush-2026-02-20from Feb 21, 2026
Merged
Fix macOS build: missing MacMSRDriver include path for numa_to_socket_example#1004rdementi merged 2 commits intopush-2026-02-20from
rdementi merged 2 commits intopush-2026-02-20from
Conversation
Merged
…mple Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compilation error on FreeBSD in domainset header
Fix macOS build: missing MacMSRDriver include path for numa_to_socket_example
Feb 21, 2026
rdementi
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, building
numa_to_socket_examplefails becausemsr.hincludes<MSRAccessor.h>(angle-bracket form), but thesrc/MacMSRDriver/directory containing that header is only added to the include path withinsrc/CMakeLists.txt— it does not propagate to the siblingexamples/directory.Fix
target_include_directoriesfornuma_to_socket_exampleinexamples/CMakeLists.txton Apple builds:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.