Skip to content

Fix macOS build: missing MacMSRDriver include path for numa_to_socket_example#1004

Merged
rdementi merged 2 commits intopush-2026-02-20from
copilot/sub-pr-1002-again
Feb 21, 2026
Merged

Fix macOS build: missing MacMSRDriver include path for numa_to_socket_example#1004
rdementi merged 2 commits intopush-2026-02-20from
copilot/sub-pr-1002-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 21, 2026

On macOS, building numa_to_socket_example fails because msr.h includes <MSRAccessor.h> (angle-bracket form), but the src/MacMSRDriver/ directory containing that header is only added to the include path within src/CMakeLists.txt — it does not propagate to the sibling examples/ directory.

Fix

  • Added target_include_directories for numa_to_socket_example in examples/CMakeLists.txt on Apple builds:
if(APPLE)
    target_include_directories(numa_to_socket_example PRIVATE "${CMAKE_SOURCE_DIR}/src/MacMSRDriver")
endif()

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…mple

Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix compilation error on FreeBSD in domainset header Fix macOS build: missing MacMSRDriver include path for numa_to_socket_example Feb 21, 2026
Copilot AI requested a review from rdementi February 21, 2026 14:08
@rdementi rdementi marked this pull request as ready for review February 21, 2026 14:10
@rdementi rdementi merged commit f322751 into push-2026-02-20 Feb 21, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants