Fix FreeBSD build: replace cpuset_getdomain with cpuset_getaffinity for NUMA domain CPU lookup#1003
Merged
rdementi merged 2 commits intopush-2026-02-20from Feb 21, 2026
Merged
Conversation
Merged
…et_getdomain Co-authored-by: rdementi <25432609+rdementi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compilation error on FreeBSD
Fix FreeBSD build: replace cpuset_getdomain with cpuset_getaffinity for NUMA domain CPU lookup
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cpuset_getdomainexpects adomainset_t *as its 5th argument, but the code was passing acpuset_t *, causing a compilation failure on FreeBSD.Changes
src/cpucounters.cpp: Replacecpuset_getdomain(CPU_LEVEL_WHICH, CPU_WHICH_DOMAIN, ..., &cpuset, DOMAINSET_POLICY_PREFER)withcpuset_getaffinity(CPU_LEVEL_WHICH, CPU_WHICH_DOMAIN, ..., &cpuset), which correctly acceptscpuset_t *and returns the set of CPUs belonging to a given NUMA domain.#include <sys/domainset.h>.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.