[SYCL] Update SYCL tests to use access_mode - #22825
Closed
KornevNikita wants to merge 6 commits into
Closed
Conversation
access::mode is deprecated in favor of access_mode. PR to add deprecations: intel#22803
KornevNikita
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Updates SYCL end-to-end tests to use access_mode (replacing deprecated access::mode) to prevent deprecation warnings and keep tests compatible with upcoming SYCL deprecations.
Changes:
- Replaced
access::mode::*withaccess_mode::*(andsycl::access::modewithsycl::access_mode) across many e2e tests. - Updated a few traced/checked outputs (e.g., XPTI accessor “mode” numeric fields) to match the new usage.
- Adjusted some test scopes/bracing to keep CHECK line references stable.
Reviewed changes
Copilot reviewed 295 out of 295 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sycl/test-e2e/XPTI/kernel/content.cpp | Switch kernel buffer accessors to access_mode. |
| sycl/test-e2e/XPTI/buffer/use_host_ptr.cpp | Switch buffer accessor template arg to sycl::access_mode. |
| sycl/test-e2e/XPTI/buffer/sub_buffer.cpp | Switch sub-buffer accessor template arg to sycl::access_mode. |
| sycl/test-e2e/XPTI/buffer/recursion.cpp | Switch accessor template arg to sycl::access_mode. |
| sycl/test-e2e/XPTI/buffer/multiple_queues.cpp | Switch accessor template args to sycl::access_mode. |
| sycl/test-e2e/XPTI/buffer/multiple_buffers.cpp | Switch accessor template args to sycl::access_mode. |
| sycl/test-e2e/XPTI/buffer/in_cycle.cpp | Switch accessor template arg to sycl::access_mode. |
| sycl/test-e2e/XPTI/buffer/host_array.cpp | Switch accessor template arg to sycl::access_mode. |
| sycl/test-e2e/XPTI/buffer/accessors.cpp | Update expected “Construct accessor” mode fields and adjust brace scoping. |
| sycl/test-e2e/WorkGroupStatic/work_group_static_memory_namespace_scope.cpp | Switch buffer accessor to access_mode. |
| sycl/test-e2e/WorkGroupStatic/work_group_static_memory_class_scope.cpp | Switch buffer accessor to access_mode. |
| sycl/test-e2e/WorkGroupStatic/work_group_static_memory_block_scope.cpp | Switch buffer accessor to access_mode. |
| sycl/test-e2e/WorkGroupScratchMemory/dynamic_allocation.cpp | Switch buffer accessor to access_mode. |
| sycl/test-e2e/WorkGroupScratchMemory/dynamic_alloc_ptr_alias.cpp | Switch buffer accessor to access_mode. |
| sycl/test-e2e/WorkGroupScratchMemory/dynamic_alloc_local_accessor.cpp | Switch buffer accessor to access_mode. |
| sycl/test-e2e/WeakObject/weak_object_utils.hpp | Switch host_accessor mode template arg to sycl::access_mode. |
| sycl/test-e2e/USM/memset.cpp | Switch buffer accessor to access_mode. |
| sycl/test-e2e/USM/memcpy.cpp | Switch buffer accessor to access_mode. |
| sycl/test-e2e/USM/math.cpp | Switch buffer accessor to s::access_mode. |
| sycl/test-e2e/USM/free_during_kernel_execution.cpp | Switch buffer accessor to sycl::access_mode. |
| sycl/test-e2e/USM/fill.cpp | Switch buffer accessor to access_mode. |
| sycl/test-e2e/Tracing/image_printers.cpp | Switch constexpr access mode to sycl::access_mode. |
| sycl/test-e2e/Tracing/buffer_printers.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/SubGroupMask/GroupSize.cpp | Switch accessor mode to access_mode. |
| sycl/test-e2e/SubGroupMask/Basic.cpp | Switch accessor mode to access_mode. |
| sycl/test-e2e/SubGroup/vote.cpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/SubGroup/scan.hpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/SubGroup/reduce.hpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/SubGroup/info.cpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/SubGroup/generic_reduce.cpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/SubGroup/common.cpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/SubGroup/broadcast.hpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/SubGroup/barrier.cpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/Scheduler/ReleaseResourcesTest.cpp | Update sycl_access_mode alias to sycl::access_mode. |
| sycl/test-e2e/Scheduler/MultipleDevices.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/Scheduler/MemObjRemapping.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/Scheduler/InOrderQueueDeps.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Scheduler/HostAccDestruction.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Scheduler/DeleteCmdException.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Scheduler/DataMovement.cpp | Update sycl_access_mode alias to sycl::access_mode. |
| sycl/test-e2e/Scheduler/CommandCleanupThreadSafety.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Scheduler/BasicSchedulerTests.cpp | Update sycl_access_mode alias to sycl::access_mode. |
| sycl/test-e2e/Sampler/unnormalized-none-nearest.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/unnormalized-none-linear-float.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/unnormalized-clampedge-nearest.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/unnormalized-clampedge-linear-float.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/unnormalized-clamp-nearest.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/unnormalized-clamp-linear-float.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-repeat-nearest.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-repeat-linear-float.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-none-nearest.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-none-linear-float.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-mirror-nearest.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-mirror-linear-float.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-clampedge-nearest.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-clampedge-linear-float.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-clamp-nearest.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/normalized-clamp-linear-float.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/basic-rw.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Sampler/basic-rw-float.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Regression/static-buffer-dtor.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/set-arg-local-accessor.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Regression/same_unnamed_kernels.cpp | Switch accessor modes in get_access and accessor type spellings. |
| sycl/test-e2e/Regression/reduction_resource_leak_dw.cpp | Switch input accessor mode to access_mode. |
| sycl/test-e2e/Regression/private_array_init_test.cpp | Switch buffer accessor mode to s::access_mode. |
| sycl/test-e2e/Regression/nontrivial_device_copyable_value.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Regression/multithread_write_accessor.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/multiple-targets.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/Regression/msvc_crt.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Regression/mad_sat.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/local-arg-align.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Regression/kernel_unnamed.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/Regression/kernel_bundle_ignore_sycl_external.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/isordered.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/implicit_offset_debug_info.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Regression/implicit_kernel_bundle_image_filtering.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/implicit_atomic_conversion.cpp | Switch atomic accessor mode to access_mode. |
| sycl/test-e2e/Regression/image_access.cpp | Switch image accessor mode template arg to sycl::access_mode. |
| sycl/test-e2e/Regression/group.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/Regression/fsycl-host-compiler.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Regression/fsycl-host-compiler-win.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Regression/fp16-with-unnamed-lambda.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/event_destruction.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/complex_global_object.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Regression/commandlist/Inputs/FindPrimesSYCL.cpp | Switch constexpr access mode variables to sycl::access_mode. |
| sycl/test-e2e/Regression/atomic_load.cpp | Switch atomic accessor mode to access_mode. |
| sycl/test-e2e/Regression/2020-spec-constants-debug-info.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Reduction/reduction_utils.hpp | Switch input accessor mode to access_mode. |
| sycl/test-e2e/Reduction/reduction_usm_dw.cpp | Switch input accessor mode to access_mode. |
| sycl/test-e2e/Reduction/reduction_usm.cpp | Switch input accessor mode to access_mode. |
| sycl/test-e2e/Reduction/reduction_range_N_vars.cpp | Switch constexpr access mode variables to access_mode. |
| sycl/test-e2e/Reduction/reduction_range_1d_rw.cpp | Switch constexpr access mode variable to access_mode. |
| sycl/test-e2e/Reduction/reduction_range_1d_reducer_skip.cpp | Switch constexpr access mode variables to access_mode. |
| sycl/test-e2e/Reduction/reduction_nd_lambda.cpp | Switch template non-type parameter from access::mode to access_mode. |
| sycl/test-e2e/Reduction/reduction_nd_ext_type.hpp | Switch constexpr access mode variables to access_mode. |
| sycl/test-e2e/Reduction/reduction_nd_conditional.cpp | Switch input accessor mode to access_mode. |
| sycl/test-e2e/Reduction/reduction_nd_N_vars.cpp | Switch constexpr access mode variables to access_mode. |
| sycl/test-e2e/Reduction/reduction_ctor.cpp | Switch device accessor mode template arg to access_mode in RW accessor. |
| sycl/test-e2e/Reduction/reduction_big_data.cpp | Switch input accessor mode to access_mode. |
| sycl/test-e2e/OptionalKernelFeatures/throw-exception-for-out-of-registers-on-kernel-launch.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/KernelParams/union_kernel_param.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/KernelParams/struct_kernel_param.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/KernelParams/non-standard-layout.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/KernelParams/array-kernel-param-run.cpp | Switch accessor modes to access_mode in buffers and accessor arrays. |
| sycl/test-e2e/KernelParams/array-kernel-param-nested-run.cpp | Switch accessor modes to access_mode in nested/accessor-array structs. |
| sycl/test-e2e/KernelCompiler/spirv.cpp | Switch set_arg accessor modes to sycl::access_mode. |
| sycl/test-e2e/KernelCompiler/opencl_capabilities.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/KernelCompiler/opencl_cache.cpp | Switch set_arg accessor modes to sycl::access_mode. |
| sycl/test-e2e/KernelCompiler/opencl.cpp | Switch set_arg accessor modes to sycl::access_mode. |
| sycl/test-e2e/KernelAndProgram/cache_env_vars.hpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/IntermediateLib/Inputs/incrementing_lib.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/InorderQueue/in_order_buffs.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/InlineAsm/asm_switch.cpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_plus_mod.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_no_output.cpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_multiple_instructions.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_mul.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_loop.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_imm_arg.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_if.cpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_float_neg.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_float_imm_arg.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_float_add.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_decl_in_scope.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_arbitrary_ops_order.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_8_no_input_int.cpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_8_empty.cpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_16_no_opts.cpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_16_no_input_int.cpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_16_matrix_mult.cpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/InlineAsm/asm_16_empty.cpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/HostInteropTask/host-task-dependency4.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/HierPar/hier_par_basic.cpp | Switch accessor types/modes to access_mode. |
| sycl/test-e2e/HierPar/Inputs/hier_par_wgscope_impl.hpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/GroupLocalMemory/no_early_opt.cpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/GroupLocalMemory/group_local_memory.cpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/GroupInterface/leader_of.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/GroupAlgorithm/leader.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/GroupAlgorithm/barrier.cpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/GroupAlgorithm/back_to_back_collectives.cpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/Functor/kernel_functor.cpp | Switch constexpr access mode to sycl::access_mode. |
| sycl/test-e2e/Functor/functor_inheritance.cpp | Switch constexpr access mode to sycl::access_mode. |
| sycl/test-e2e/FreeFunctionKernels/template_specialization.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/FreeFunctionKernels/enum_parameter.cpp | Switch accessor mode types/template params to access_mode. |
| sycl/test-e2e/FreeFunctionKernels/accessor_as_kernel_parameter.cpp | Switch accessor mode types/template args to sycl::access_mode. |
| sycl/test-e2e/Experimental/reusable_events/wait_multiple_events.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/Experimental/reusable_events/queue_returned_events.cpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/Experimental/reusable_events/out_of_order_queue_signal.cpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/Experimental/reusable_events/kernel_timing.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/Experimental/reusable_events/in_order_queue_signal.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/Experimental/reusable_events/event_reuse.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/Experimental/reusable_events/event_reassociation_dependency.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/Experimental/reusable_events/event_as_dependency.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/Experimental/reusable_events/cross_queue_dependency.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/Experimental/launch_queries/max_work_item_sizes.cpp | Switch accessor type + get_access mode to sycl::access_mode. |
| sycl/test-e2e/Experimental/launch_queries/max_work_group_size.cpp | Switch accessor type + get_access mode to sycl::access_mode. |
| sycl/test-e2e/Experimental/launch_queries/max_sub_groups.cpp | Switch accessor type + get_access mode to sycl::access_mode. |
| sycl/test-e2e/Experimental/launch_queries/max_sub_group_size.cpp | Switch accessor type + get_access mode to sycl::access_mode. |
| sycl/test-e2e/Experimental/launch_queries/max_num_work_groups.cpp | Switch accessor type + get_access mode to sycl::access_mode. |
| sycl/test-e2e/DeviceLib/std_complex_math_test.cpp | Switch constexpr access mode vars to s::access_mode. |
| sycl/test-e2e/DeviceLib/std_complex_math_fp64_test.cpp | Switch constexpr access mode vars to s::access_mode. |
| sycl/test-e2e/DeviceLib/rand_test.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/DeviceLib/math_windows_test.cpp | Switch constexpr access mode vars to s::access_mode. |
| sycl/test-e2e/DeviceLib/math_test.cpp | Switch constexpr access mode vars to s::access_mode. |
| sycl/test-e2e/DeviceLib/math_override_test.cpp | Switch constexpr access mode vars to s::access_mode. |
| sycl/test-e2e/DeviceLib/math_fp64_windows_test.cpp | Switch constexpr access mode vars to s::access_mode. |
| sycl/test-e2e/DeviceLib/math_fp64_test.cpp | Switch constexpr access mode vars to s::access_mode. |
| sycl/test-e2e/DeviceLib/imf/simd_emulate_test.cpp | Switch constexpr access mode vars to s::access_mode. |
| sycl/test-e2e/DeviceLib/imf/fp64_test.cpp | Switch constexpr access mode vars to s::access_mode. |
| sycl/test-e2e/DeviceLib/imf/fp32_test.cpp | Switch constexpr access mode vars to s::access_mode. |
| sycl/test-e2e/DeviceLib/complex_utils.hpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/DeviceLib/cmath_test.cpp | Switch constexpr access mode vars to s::access_mode. |
| sycl/test-e2e/DeviceLib/cmath_fp64_test.cpp | Switch constexpr access mode vars to s::access_mode. |
| sycl/test-e2e/DeviceLib/c99_complex_math_test.cpp | Switch constexpr access mode var to s::access_mode. |
| sycl/test-e2e/DeviceLib/c99_complex_math_fp64_test.cpp | Switch constexpr access mode var to s::access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/vector_common.cpp | Switch accessor mode to s::access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/scalar_common.cpp | Switch accessor mode to s::access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/nan.cpp | Switch accessor mode to s::access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/fast-math-flag.cpp | Switch accessor mode template args to access_mode. |
| sycl/test-e2e/DeviceLib/built-ins/ext_native_math_common.hpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/DeviceLib/bfloat16_conversion_test.hpp | Switch constexpr access mode vars to access_mode. |
| sycl/test-e2e/DeviceLib/bfloat16_conversion_dlopen_test.hpp | Switch constexpr access mode vars to access_mode. |
| sycl/test-e2e/DeviceLib/ITTAnnotations/barrier.cpp | Switch accessor mode to access_mode. |
| sycl/test-e2e/DeviceLib/ITTAnnotations/atomic.cpp | Switch accessor mode to access_mode (partial). |
| sycl/test-e2e/DeviceGlobal/device_global_subscript.hpp | Switch accessor mode to access_mode. |
| sycl/test-e2e/DeviceGlobal/device_global_static.cpp | Switch accessor mode to access_mode. |
| sycl/test-e2e/DeviceGlobal/device_global_operator_passthrough.hpp | Switch accessor mode to access_mode. |
| sycl/test-e2e/DeviceGlobal/device_global_device_only.hpp | Switch accessor mode to access_mode. |
| sycl/test-e2e/DeviceGlobal/device_global_arrow.hpp | Switch accessor mode to access_mode. |
| sycl/test-e2e/DeviceArchitecture/device_architecture_on_device_aot.cpp | Switch accessor mode to access_mode. |
| sycl/test-e2e/DeprecatedFeatures/set_arg_interop.cpp | Switch accessor mode template args to access_mode. |
| sycl/test-e2e/DeprecatedFeatures/DiscardEvents/discard_events_accessors.cpp | Switch accessor mode to sycl::access_mode. |
| sycl/test-e2e/Config/kernel_from_file.cpp | Switch accessor mode to access_mode. |
| sycl/test-e2e/Config/env_vars.cpp | Switch accessor mode to access_mode. |
| sycl/test-e2e/ClusterLaunch/enqueueLaunchCustom_check_event_deps.cpp | Switch accessor modes to sycl::access_mode. |
| sycl/test-e2e/Basic/vector/byte.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/use_pinned_host_memory.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/unused_pointer.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/sycl-namespace.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/subdevice_pi.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Basic/span.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Basic/queue/queue_shortcut_functions.cpp | Switch accessor mode template args to sycl::access_mode. |
| sycl/test-e2e/Basic/parallel_for_user_types.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/parallel_for_indexers.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Basic/offset-accessor-get_pointer.cpp | Switch constexpr access mode var to access_mode. |
| sycl/test-e2e/Basic/nested_queue_submit.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/multisource_spv_obj.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/Basic/multisource.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/Basic/multi_ptr_null_relational_operators.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/multi_ptr_legacy.hpp | Switch accessor mode template args to access_mode. |
| sycl/test-e2e/Basic/multi_ptr.hpp | Switch accessor mode template args to access_mode. |
| sycl/test-e2e/Basic/linear-sub_group.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Basic/kernel_info_attr.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Basic/kernel_info.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Basic/kernel_bundle/kernel_bundle_api_hip.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/kernel_bundle/kernel_bundle_api.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/interop/make_kernel_subdevice_l0.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Basic/image/srgba-read.cpp | Switch image/buffer accessor modes to access_mode. |
| sycl/test-e2e/Basic/image/image_trace.cpp | Switch constexpr access modes to sycl::access_mode. |
| sycl/test-e2e/Basic/image/image_sample.cpp | Switch image/buffer accessor modes to s::access_mode. |
| sycl/test-e2e/Basic/image/image_read.h | Switch image/buffer accessor modes to s::access_mode. |
| sycl/test-e2e/Basic/image/image_max_size.cpp | Switch image accessor modes to access_mode. |
| sycl/test-e2e/Basic/image/image_array.cpp | Switch constexpr access modes to sycl::access_mode. |
| sycl/test-e2e/Basic/image/image_accessor_readwrite_half.cpp | Switch image/buffer accessor modes to s::access_mode. |
| sycl/test-e2e/Basic/image/image_accessor_readwrite.cpp | Switch image/buffer accessor modes to s::access_mode. |
| sycl/test-e2e/Basic/image/image_accessor_readsampler.cpp | Switch image/buffer accessor modes to s::access_mode. |
| sycl/test-e2e/Basic/image/image_accessor_range.cpp | Switch image accessor mode template args to access_mode. |
| sycl/test-e2e/Basic/image/image.cpp | Switch constexpr access modes and image accessor template arg to sycl::access_mode. |
| sycl/test-e2e/Basic/handler/handler_generic_integral_lambda.cpp | Switch accessor mode template args to sycl::access_mode. |
| sycl/test-e2e/Basic/handler/handler_copy_with_offset.cpp | Switch constexpr access mode vars to access_mode. |
| sycl/test-e2e/Basic/half_builtins.cpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/Basic/group_async_copy_legacy.cpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/Basic/group_async_copy.cpp | Switch accessor modes to access_mode. |
| sycl/test-e2e/Basic/get_backend.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Basic/free_function_queries/free_function_queries_sub_group.cpp | Switch accessor mode template args to sycl::access_mode. |
| sycl/test-e2e/Basic/fill_accessor.cpp | Switch accessor mode template arg to sycl::access_mode. |
| sycl/test-e2e/Basic/event_profiling_info.cpp | Switch accessor mode template args to access_mode. |
| sycl/test-e2e/Basic/event.cpp | Switch buffer accessor mode to sycl::access_mode. |
| sycl/test-e2e/Basic/device_event.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Basic/compare_exchange_strong.cpp | Switch atomic+result accessor modes to access_mode. |
| sycl/test-e2e/Basic/char_builtins.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/Basic/built-ins.cpp | Switch buffer accessor modes to s::access_mode. |
| sycl/test-e2e/Basic/buffer/reinterpret.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/Basic/buffer/native_buffer_creation_flags.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Basic/buffer/buffer_container.cpp | Switch buffer accessor mode to access_mode. |
| sycl/test-e2e/Basic/bit_cast/bit_cast.cpp | Switch constexpr access mode var to sycl::access_mode. |
| sycl/test-e2e/Basic/alloc_pinned_host_memory.cpp | Switch buffer accessor modes to access_mode. |
| sycl/test-e2e/Basic/access_to_subset.cpp | Switch accessor type alias to access_mode. |
| sycl/test-e2e/AtomicRef/xor.h | Switch cumulative accessor mode to access_mode. |
| sycl/test-e2e/AtomicRef/sub.h | Switch value accessors to access_mode. |
| sycl/test-e2e/AtomicRef/store.h | Switch store accessor mode to access_mode. |
| sycl/test-e2e/AtomicRef/or.h | Switch cumulative accessor mode to access_mode. |
| sycl/test-e2e/AtomicRef/min.h | Switch cumulative/value accessor mode to access_mode. |
| sycl/test-e2e/AtomicRef/max.h | Switch cumulative/value accessor mode to access_mode. |
| sycl/test-e2e/AtomicRef/load.h | Switch load accessor mode to access_mode. |
| sycl/test-e2e/AtomicRef/exchange.h | Switch exchange accessor mode to access_mode (partial). |
| sycl/test-e2e/AtomicRef/compare_exchange.h | Switch compare_exchange accessor mode to access_mode. |
| sycl/test-e2e/AtomicRef/atomic_memory_order_seq_cst.cpp | Switch various accessor modes to access_mode (partial). |
| sycl/test-e2e/AtomicRef/atomic_memory_order_acq_rel.cpp | Switch various accessor modes to access_mode. |
| sycl/test-e2e/AtomicRef/assignment.h | Switch assignment accessor mode to access_mode. |
| sycl/test-e2e/AtomicRef/and.h | Switch cumulative accessor mode to access_mode. |
| sycl/test-e2e/AtomicRef/add.h | Switch sum accessor modes to access_mode. |
| sycl/test-e2e/AddressCast/static_address_cast.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/AddressCast/khr_static_addrspace_cast.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/AddressCast/khr_dynamic_addrspace_cast.cpp | Switch buffer accessor modes to sycl::access_mode. |
| sycl/test-e2e/AddressCast/dynamic_address_cast.cpp | Switch buffer accessor modes to sycl::access_mode. |
Suppressed comments (2)
sycl/test-e2e/XPTI/buffer/accessors.cpp:1
- The CHECK expectations now encode
1025/1026(which typically correspond towrite/read_write) while the code constructsdiscard_writeanddiscard_read_writeaccessors. This makes the test internally inconsistent and likely to fail or become misleading. Align either (a) the expected numeric mode fields with the discard modes, or (b) the accessor modes used in code with the expected values (e.g., use non-discard modes if discard modes are no longer supposed to be observed here).
sycl/test-e2e/DeviceLib/ITTAnnotations/atomic.cpp:1 - This file still uses the deprecated
access::mode(discard_write) after migrating other accessors toaccess_mode. To fully meet the PR goal (avoidaccess::modedeprecation), update the remainingaccess::mode::discard_write(and any similar leftover modes in this file) toaccess_mode::discard_write.
Contributor
Author
|
Too many changes, closing in favor of smaller patches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
access::mode is deprecated in favor of access_mode.
PR to add deprecations: #22803