[SYCL] Update ESIMD tests to use access_mode - #22821
Merged
Merged
Conversation
access::mode is deprecated in favor of access_mode. discard_write and discard_read_write are deprecated in favor of regular read and read_write with no_init property. PR to add deprecations: intel#22803
Contributor
There was a problem hiding this comment.
Pull request overview
Updates SYCL ESIMD end-to-end tests to use access_mode instead of the deprecated access::mode, aligning the test suite with SYCL 2020 and the deprecation work referenced in #22803. The changes are mechanical (API spelling/namespace updates) and do not alter kernel control flow, so they should not impact profiling data or debug info generation.
Changes:
- Replace
access::mode::{...}template arguments withaccess_mode::{...}across ESIMD tests. - Update fully-qualified uses (e.g.,
sycl::access::mode) tosycl::access_modewhere needed (including constants used as accessor template parameters).
Reviewed changes
Copilot reviewed 87 out of 87 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sycl/test-e2e/ESIMD/vadd_2d.cpp | Update image accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/vadd_2d_acc.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/vadd_1d.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/unified_memory_api/Inputs/atomic_update.hpp | Update buffer accessor mode to access_mode in atomic test. |
| sycl/test-e2e/ESIMD/template.cpp | Update buffer accessor mode to access_mode in templated kernel helper. |
| sycl/test-e2e/ESIMD/sycl_esimd_mix.cpp | Update buffer accessor mode to access_mode for mixed SYCL/ESIMD kernels. |
| sycl/test-e2e/ESIMD/spec_const/spec_const_redefine.cpp | Update specialization-constant test accessor mode to sycl::access_mode. |
| sycl/test-e2e/ESIMD/spec_const/Inputs/spec-const-2020-common.hpp | Update specialization-constant test accessor mode to sycl::access_mode. |
| sycl/test-e2e/ESIMD/regression/variable_gather_mask.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/regression/unused_load.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/regression/tanh_fix_test.cpp | Update accessor mode constant to sycl::access_mode. |
| sycl/test-e2e/ESIMD/regression/sycl_esimd_mixed_unnamed.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/regression/operator_decrement.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/regression/half_conversion_test.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/regression/fmod_compatibility_test.cpp | Update accessor mode constant to sycl::access_mode. |
| sycl/test-e2e/ESIMD/regression/copyto_char_test.cpp | Update accessor mode to sycl::access_mode. |
| sycl/test-e2e/ESIMD/regression/big_const_initializer.cpp | Update accessor mode to sycl::access_mode. |
| sycl/test-e2e/ESIMD/popcount.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/noinline_call_from_func.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/named_barriers/single_wg.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/named_barriers/multiple_wg.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/named_barriers/loop.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/named_barriers/loop_extended.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/named_barriers/exec_in_order.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/named_barriers/exec_in_order_branched.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/named_barriers/allocate_barrier.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/matrix_transpose2.cpp | Update image accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/matrix_transpose.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/mask_expand_load.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/mask_compress_store_acc.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/mandelbrot/mandelbrot.cpp | Update image accessor mode to sycl::access_mode. |
| sycl/test-e2e/ESIMD/mandelbrot/mandelbrot_spec.cpp | Update image accessor mode to sycl::access_mode. |
| sycl/test-e2e/ESIMD/lsc/lsc_slm.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/lsc/lsc_predicate.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/lsc/lsc_predicate_stateless.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_gather_scatter.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/lsc/lsc_gather_scatter_stateless_64.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/lsc/lsc_block_load_store_stateless_64.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/lsc/lsc_argument_type_deduction.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/lsc/Inputs/lsc_surf.hpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/lsc/Inputs/lsc_surf_store.hpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/lsc/Inputs/lsc_surf_load.hpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/lsc/atomic_smoke.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/local_accessor_gather_scatter.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/local_accessor_gather_scatter_rgba.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/linear/linear.cpp | Update image accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/InlineAsm/asm_vadd.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/InlineAsm/asm_simd_view.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/InlineAsm/asm_simd_mask.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/InlineAsm/asm_glb.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/histogram.cpp | Update image accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/histogram_2d.cpp | Update image accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/grf.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/frem.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/fp_in_select.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/fp_in_phi.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/fp_call_from_func.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/fma.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/ext_math.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/clz_ctz.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/BitonicSortK.hpp | Update buffer accessor modes to access_mode in bitonic sort kernels. |
| sycl/test-e2e/ESIMD/api/slm_gather_scatter_heavy.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/api/simd_view_subscript_operator.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/api/simd_view_negation_operator.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/api/simd_view_copy_move_assign.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/api/simd_subscript_operator.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/api/simd_negation_operator.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/api/simd_memory_access.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/api/simd_copy_to_from.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/api/simd_copy_to_from_stateful.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/api/simd_binop_integer_promotion.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/api/saturation_smoke.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/api/replicate_smoke.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/api/functional/operators/operator_assignment_glb.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/api/functional/operators/operator_assignment_glb_mask.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/api/ballot.cpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/aot_mixed.cpp | Update buffer accessor modes to access_mode in AOT mixed test. |
| sycl/test-e2e/ESIMD/accessor.hpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/accessor_stateless_ctor_64.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/accessor_stateless_64.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/accessor_load_store.hpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/accessor_load_store_stateless_64.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/accessor_gather_scatter.hpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/accessor_gather_scatter_stateless_64.cpp | Update buffer accessor mode to access_mode. |
| sycl/test-e2e/ESIMD/acc_gather_scatter_rgba.hpp | Update buffer accessor modes to access_mode. |
| sycl/test-e2e/ESIMD/acc_gather_scatter_rgba_stateless_64.cpp | Update buffer accessor mode to access_mode. |
KornevNikita
marked this pull request as ready for review
July 30, 2026 17:00
sarnex
approved these changes
Jul 30, 2026
crystarm
pushed a commit
to crystarm/intel-llvm
that referenced
this pull request
Jul 31, 2026
access::mode is deprecated in favor of access_mode. PR to add deprecations: intel#22803
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
access::mode is deprecated in favor of access_mode.
PR to add deprecations: #22803