Skip to content

[UR][L0] Don't batch external semaphore operations #22811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jabrad wants to merge 1 commit into
base: sycl
Choose a base branch
from
+14 −4
Open

[UR][L0] Don't batch external semaphore operations #22811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions unified-runtime/source/adapters/level_zero/image.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,13 @@ ur_result_t urBindlessImagesWaitExternalSemaphoreExp(

bool UseCopyEngine = false;

// We want to batch these commands to avoid extra submissions (costly)
bool OkToBatch = true;
// External semaphore operations must not be deferred in a batch. With
// regular (non-immediate) command lists, batching leaves the append sitting
// in the queue's open command list until some unrelated event flushes it.
// For a signal that means the external consumer may never observe it; for a
// wait it means the external producer's signal cannot release a command
Comment on lines +121 to +125
Comment on lines +121 to +125
// list that was never submitted, which can deadlock.
bool OkToBatch = false;

ur_ze_event_list_t TmpWaitList;
UR_CALL(TmpWaitList.createAndRetainUrZeEventList(
Expand Down Expand Up @@ -176,8 +181,13 @@ ur_result_t urBindlessImagesSignalExternalSemaphoreExp(

bool UseCopyEngine = false;

// We want to batch these commands to avoid extra submissions (costly)
bool OkToBatch = true;
// External semaphore operations must not be deferred in a batch. With
// regular (non-immediate) command lists, batching leaves the append sitting
// in the queue's open command list until some unrelated event flushes it.
// For a signal that means the external consumer may never observe it; for a
// wait it means the external producer's signal cannot release a command
// list that was never submitted, which can deadlock.
bool OkToBatch = false;

ur_ze_event_list_t TmpWaitList;
UR_CALL(TmpWaitList.createAndRetainUrZeEventList(
Expand Down
Loading