Skip to content

[SYCL][UR] Fix DX11 bindless-images interop crashes on Windows - #22795

Open
mateuszpn wants to merge 4 commits into
intel:syclfrom
mateuszpn:win-dx11-binless-fix
Open

[SYCL][UR] Fix DX11 bindless-images interop crashes on Windows#22795
mateuszpn wants to merge 4 commits into
intel:syclfrom
mateuszpn:win-dx11-binless-fix

Conversation

@mateuszpn

@mateuszpn mateuszpn commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Enabled both DX11 bindless-images interop tests (read_write_unsampled.cpp, read_write_unsampled_semaphore.cpp) for all architectures that support bindless images, after fixing two bugs that prevented them from passing on Win BMG and Win DG2:

  • a data race/lock leak in the image handle map, and
  • a rejected D3D11 external-fence import (now falls back to D3D12_FENCE).

Gen12 does not support bindless images at all, which both tests require internally — for clarity, the hardcoded architecture blocker (UNSUPPORTED: gpu-intel-gen12/dg2/bmg_g21) is replaced with a REQUIRES: aspect-ext_oneapi_bindless_images check, so any device lacking the aspect is skipped the same way instead of crashing.

@mateuszpn
mateuszpn force-pushed the win-dx11-binless-fix branch from e94db13 to 53d5dbe Compare July 29, 2026 12:32
@mateuszpn mateuszpn changed the title [SYCL][UR] Fix dx11 issue [SYCL][UR] Fix DX11 bindless-images interop crashes on Windows Jul 30, 2026
@mateuszpn
mateuszpn marked this pull request as ready for review July 30, 2026 13:37
@mateuszpn
mateuszpn requested review from a team as code owners July 30, 2026 13:38
@mateuszpn
mateuszpn requested a review from 0x12CC July 30, 2026 13:38

@dyniols dyniols left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bindless image changes lgtm. Thanks for fixing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants