[v12] feat(ui-tag): rework Tag #2310
Open
+74
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToMESSKa
force-pushed
the
INSTUI-4811-tag-rework
branch
from
9091e5a to
0c16227
Compare
|
INSTUI-4811
ToMESSKa
force-pushed
the
INSTUI-4811-tag-rework
branch
from
0c16227 to
f4a0f10
Compare
adamlobler
approved these changes
Dec 16, 2025
Collaborator
adamlobler
left a comment
adamlobler
left a comment
There was a problem hiding this comment.
Looks good to me! I added Dorka as a reviewer since the tokens were created by her.
balzss
approved these changes
Dec 23, 2025
matyasf
requested changes
Jan 5, 2026
| "@instructure/shared-types": "workspace:*", | ||
| "@instructure/ui-color-utils": "workspace:*", | ||
| "@instructure/ui-dom-utils": "workspace:*", | ||
| "@instructure/ui-icons": "workspace:*", |
Collaborator
There was a problem hiding this comment.
The ui-icons dependency is no longer used, you can remove it
| {onClick && dismissible ? ( | ||
| <XInstUIIcon | ||
| css={styles?.icon} | ||
| size={variant === 'inline' ? 14 : 'sm'} |
Collaborator
There was a problem hiding this comment.
AFAIK we should always use semantic tokens, 14 should be an invalid value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-4811
ISSUE:
TEST PLAN: