[FUP Optimisation] redis: added endpoint filtering#688
Merged
CagriYonca merged 1 commit intomainfrom Feb 5, 2025
Merged
Conversation
3383d8c to
43b13cd
Compare
pvital
requested changes
Jan 29, 2025
Member
pvital
left a comment
There was a problem hiding this comment.
Well done, @CagriYonca, but I still have some comments.
43b13cd to
b900400
Compare
b900400 to
272639c
Compare
pvital
requested changes
Jan 31, 2025
Member
pvital
left a comment
There was a problem hiding this comment.
Few more request changes.
As discussed in our call, let's change the approach and filter the spans before sending them to the Agent (or Collector) - see src/instana/agent/host.py:300. That way, we can have a one-size-fits-all solution, and no changes to the instrumentation code will be necessary.
272639c to
dc9b718
Compare
dc9b718 to
352c993
Compare
Signed-off-by: Cagri Yonca <cagri@ibm.com>
352c993 to
d8557b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added endpoint filtering for redis instrumentation. We've aligned with Java and NodeJS teams. The customer has three options to filter endpoints:
If the customer used more than one way of these three, we'd be using one according to this priority:
Ignoring endpoints through env variable
The customer can use filtering with the environment variable below. If the env variable is set, other two ways will be ignored.
INSTANA_IGNORE_ENDPOINTS="service:endpoint"INSTANA_IGNORE_ENDPOINTS="service:endpoint1,endpoint2"INSTANA_IGNORE_ENDPOINTS="service"INSTANA_IGNORE_ENDPOINTS="service1:endpoint1;service2:endpoint1"INSTANA_IGNORE_ENDPOINTS="service1;service2"Ignoring endpoints through the configurator.py file
The customer can add a configuration line like below:
config["tracing"]["ignore_endpoints"] = {"service1": ["endpoint1", "endpoint2"], "service2": []}Ignoring endpoints through the agent configuration
The customer can add a configuration to agent-folder/etc/instana/configuration.yaml
Reference: https://github.ibm.com/instana/technical-documentation/tree/master/tracing/specification#ignoring-endpoints