QC testing, bug fixing and improvements in superfloat_oxygen#131
Open
CarolinaAmadio wants to merge 22 commits into
Open
QC testing, bug fixing and improvements in superfloat_oxygen#131CarolinaAmadio wants to merge 22 commits into
CarolinaAmadio wants to merge 22 commits into
Conversation
- Remove unused save_report import from commons_local - Add save_df_report function to handle CSV report saving and deduplication - Update Metadata.offset default from -999 to NaN - Improve report handling robustness and directory creation
… and add documentation
- Added full docstring for clim_check - Fixed trend check bug (TREND_per_YEAR instead of TREND_TIME_SERIES) - Improved handling of missing or weak trends
- Before: skipped trend analysis if any NaN was present in VAR at Depth == 600
- After: skip trend analysis only if time series is too short or last 3 recent
observations at 600m are all NaN
- Rewrote function documentation for clarity and correctness - Fixed NaN handling using safe numeric conversion (pd.to_numeric with errors='coerce') - Replaced original index-based logic with interpolation-based core extraction - Added explicit check for empty time series (return False if no valid data) - Improved criterion: valid if core length > 50% of original series
- Switch to read_adjusted=True for TEMP and PSAL in oxygen conversion - Add fallback to real-time data when adjusted data is missing or insufficient - Ensure density is computed from best available T/S profiles
- Distinguish TEMP and PSAL pressure arrays (PresT vs Pres) - Fallback to real-time data when adjusted TEMP/PSAL are unavailable or too short - Interpolate TEMP onto PSAL pressure grid when dimensions mismatch
Avoids potential shape mismatch when applying the mask.
…error if none available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the superfloat_oxygen script to:
Enable saving statistical information for QC analysis.
Add a drift attribute when the BGC-Argo profile value at 600 m is modified.
Clarify and better document functions.
Fix two bugs (3 bugs).