fix(open-knowledge): doc-end paste unclosed-fence content loss (#2741)#691
Merged
Conversation
* fix(open-knowledge): unclosed-fence serialize fixed point + JSX-close separator tolerance A doc-end source paste that glues onto a closing fence line reopens the fence to EOF; serialize materialized the parser's auto-close, an untracked fragment/Y.Text divergence whose watchdog remediation merges dropped content from both CRDTs. Capture sourceUnclosedFence at parse and re-emit the block without a close while it remains the document's last block. The same paste mechanism lands content a single newline after a JSX container close tag; extend bridge normalize step 6b (comparison-only) with whole-line capitalized JSX close tags so the canonical blank-line form compares equal instead of looping corrective writes. Fuzz seeds 1784396512105 / 1784396511334 / 1784396511392 now pass 3/3; 2201 residual is a distinct merge-interleave invariant (evidence banked). * docs(open-knowledge): append chunk-glue fence fix PR-gate residual measurements 1000-seed measure:fuzz: 6/1000 (0.60%), inside the healthy band; all triaged failing seeds carry the pre-existing merge-interleave signature (verified to also fail on unfixed baseline 9d43f4d22). measure:stress: pass (87 edits, 5 clients, convergence 1510ms). * fix(open-knowledge): drop stray npm-style config, address review test gaps Remove the 128-line npm/yarn-style workspaces/overrides/patchedDependencies block that leaked into package.json from pre-existing worktree state (pnpm ignores it; pnpm-workspace.yaml is canonical). Narrow sourceUnclosedFence mdast type to the produced domain (?: true). Add an indented unclosed-fence byte-stability pin and replace the over-determined open-tag negative with a whole-line marker-requirement negative. * test(open-knowledge): pin depth-0 open-tag exclusion in normalize 6b negatives GitOrigin-RevId: 80377a6b8426899740dad5bd200f0f76f7f0cc66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 1 Inkeep OSS change. Rebase-merge this PR so the prepared commit lands directly on public main.