fix(agents-api): prevent double content in streamed response finalization#3474
Closed
amikofalvy wants to merge 1 commit into
Closed
fix(agents-api): prevent double content in streamed response finalization#3474amikofalvy wants to merge 1 commit into
amikofalvy wants to merge 1 commit into
Conversation
… into pendingTextBuffer The IncrementalStreamParser.finalize() method had a bug where text content could be pushed to collectedParts twice when the buffer contained incomplete artifact markers. streamPart() was called with the buffer text, unconditionally pushing to collectedParts, but if hasIncompleteArtifact returned true it wouldn't flush pendingTextBuffer. The subsequent pendingTextBuffer cleanup would then push to collectedParts again, causing persisted messages to contain duplicate text parts. Fix: merge buffer directly into pendingTextBuffer in finalize() instead of routing through streamPart(). The combined text is cleaned of artifact tags and pushed to collectedParts exactly once. Resolves PRD-7514
amikofalvy
had a problem deploying
to
inkeep-oss-sync
July 21, 2026 21:00 — with 
GitHub Actions
Error
GitHub Actions
Error
🦋 Changeset detectedLatest commit: 1ac563d The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Thanks for the contribution! What happens next:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in
IncrementalStreamParser.finalize()that caused text content to be pushed tocollectedPartstwice when the buffer contained incomplete artifact markers at stream end. This resulted in persisted messages having duplicate text parts, which caused "double content" when conversations were replayed in the widget.Problem
In
finalize():streamPart()was called with the remaining buffer text, unconditionally pushing it tocollectedPartshasIncompleteArtifactreturnedtrue,streamPartwould NOT flushpendingTextBuffer(buffering it for later)pendingTextBuffercleanup block would then push the (cleaned) text tocollectedPartsagainThis meant the same text appeared twice in the response parts array that gets persisted to the database, and then appeared doubled when the conversation was replayed via the widget.
Fix
Instead of routing the remaining buffer through
streamPart()(which has the unconditional push + conditional flush split), merge it directly intopendingTextBuffer. The combined text is then cleaned of artifact tags and pushed tocollectedPartsexactly once.Testing
Changeset
@inkeep/agents-apipatch — "Fix duplicate content in streamed responses caused by double-push in finalize"Resolves PRD-7514
Linear Issue: PRD-7514