Skip to content

Conversation

@Sl1mb0
Copy link
Contributor

@Sl1mb0 Sl1mb0 commented Nov 21, 2025

Closes #152

Describe your proposed changes here.

  • I've read the contributing section of the project CONTRIBUTING.md.
  • Signed CLA (if not already signed).

@Sl1mb0 Sl1mb0 force-pushed the tm/influxdata-cpython branch from bef3e4a to 0972a12 Compare December 4, 2025 14:29
@Sl1mb0 Sl1mb0 force-pushed the tm/influxdata-cpython branch from 0972a12 to d1cdc68 Compare December 4, 2025 15:24
@Sl1mb0 Sl1mb0 requested a review from crepererum December 4, 2025 15:31
@Sl1mb0 Sl1mb0 force-pushed the tm/influxdata-cpython branch from d1cdc68 to 73611f3 Compare December 4, 2025 15:33
@crepererum
Copy link
Collaborator

Something about the new python build is odd. From the build logs:

inflating: python-sdk/lib/logging/handlers.py  

However if I look at the current main and the sdk there, that file sits in

python-sdk/lib/python3.14/logging/handlers.py

That's also why the tests fail, see https://github.com/influxdata/datafusion-udf-wasm/blob/main/CONTRIBUTING.md#python-fails-to-start--no-module-named-encodings

Looking at https://github.com/influxdata/cpython-wasi-build/commits/main/ I think we've messed up the branching a bit here: you've forked that project from

https://github.com/brettcannon/cpython-wasi-build/commits/main/

which is the dev branch for Python 3.15, but you should have forked it from

https://github.com/brettcannon/cpython-wasi-build/commits/release/3.14

So my suggestion is to:

  1. create a clean fork from the 3.14 branch and also name our branch release/3.14 to avoid that confusion
  2. delete all releases
  3. trigger a new release build
  4. try again here

@Sl1mb0 Sl1mb0 force-pushed the tm/influxdata-cpython branch from 73611f3 to a656cbb Compare December 5, 2025 13:37
@Sl1mb0 Sl1mb0 force-pushed the tm/influxdata-cpython branch from a656cbb to 5d2f648 Compare December 5, 2025 13:41
@Sl1mb0
Copy link
Contributor Author

Sl1mb0 commented Dec 5, 2025

finally 😅

@Sl1mb0 Sl1mb0 added this pull request to the merge queue Dec 8, 2025
Merged via the queue into main with commit a9cde19 Dec 8, 2025
1 check passed
@Sl1mb0 Sl1mb0 deleted the tm/influxdata-cpython branch December 8, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optionally Pull CPython binary from InfluxData

3 participants