Client Migration#19
Open
cfmarais-eng wants to merge 156 commits into
Open
Conversation
…VON_peer initally
- Added Simulator and Visualiser
- TODO: Implement the END command, to kill the node process - TODO: Kill the node process when an incorrect instruction is read
…S/NACKS and a timeout.
Member
|
Wow since 10 years ago. What happened lol |
Member
|
hi @cfmarais-eng @vic3e @Debojyoti1915001 could you resolve the conflicts? |
Member
|
Seems that there are some filepath changes? |
Collaborator
|
Hi Mattew,
My apologies for the delay. Were you able to resolve this issue?
I know we have changed the codebase significantly hence the conflicts.
Please let me know, perhaps we can schedule something.
Regards,
Victory
…On Sat, Feb 25, 2023 at 9:43 PM BlueT - Matthew Lien - 練喆明 < ***@***.***> wrote:
Seems that there are some filepath changes?
—
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG4NDAUICAKWCLBBYSIEQPLWZJOF3ANCNFSM57OJIBZQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Regards,
Victory
|
Member
|
Hi @vic3e , would you mind resolving the listed conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty big update. Client join and movement procedure redesigned.
Subscription migrations and updates added but relatively untested.
Simulator supports client movement requests.