Skip to content

(MOT-4299) fix(release): stage frontend bundles in a non-hidden directory - #748

Merged
ytallo merged 1 commit into
mainfrom
fix/frontend-bundle-hidden-dir
Aug 7, 2026
Merged

(MOT-4299) fix(release): stage frontend bundles in a non-hidden directory#748
ytallo merged 1 commit into
mainfrom
fix/frontend-bundle-hidden-dir

Conversation

@ytallo

@ytallo ytallo commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #747: eval/v0.2.1-experimental built every bundle correctly but uploaded an empty artifact — upload-artifact defaults to include-hidden-files: false, and pointing the path at .release-frontend-bundle/ itself makes the dot-directory the glob root, excluding everything. The old layout only worked by accident (its search root was a child of the dot dir). Renamed the staging dir to release-frontend-bundle — no hidden semantics in a CI-only path.

The repo-rooted upload from #747 pointed upload-artifact at
.release-frontend-bundle/ itself — and with the action's default
include-hidden-files: false, a dot-directory as the glob root excludes
everything: 'No files were found'. The previous layout only worked by
accident because its search root was a child of the dot-directory.

eval/v0.2.1-experimental built every bundle correctly (the dists are in
the job log) and still shipped an empty artifact. Drop the dot: hidden
semantics have no business in a CI staging path.
@vercel

vercel Bot commented Aug 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview Aug 7, 2026 4:54pm
workers-tech-spec Ready Ready Preview Aug 7, 2026 4:54pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ytallo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e3a28dc7-ffaa-4849-b4ed-613961a473f7

📥 Commits

Reviewing files that changed from the base of the PR and between 43504a2 and 0df67ca.

📒 Files selected for processing (1)
  • .github/workflows/_rust-binary.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 56 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@ytallo ytallo changed the title fix(release): stage frontend bundles in a non-hidden directory (MOT-4299) fix(release): stage frontend bundles in a non-hidden directory Aug 7, 2026
@ytallo
ytallo merged commit 937f859 into main Aug 7, 2026
17 of 18 checks passed
@ytallo
ytallo deleted the fix/frontend-bundle-hidden-dir branch August 7, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant