Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin
III_TELEMETRY_ENABLED=falsein CI, campaign/supervisor launchers, generated Compose/Docker environments, and subject execution boundaries. Apply it after caller environment merges and restore it across cleared environments, bubblewrap, and Docker execution while preserving provider secret allowlists and OpenTelemetry settings.Validation completed locally before publication: Rust all-target tests passed (716 passed, 1 ignored), the combined Python selection passed (167/167), fixture lifecycle tests passed (14), and a real Docker probe/grandchild both observed the opt-out despite an enabled parent. Formatting and syntax checks passed.
Rust validation used a canonical
TMPDIRfor an existing macOS cleanup-path mismatch. Full exact-stack/LLM, supervisor, and Linux bubblewrap runtime validation was not run; the supervisor's existing reference to missingscripts/release_control_campaign.pyis outside this change.Publication follow-up: CI exposed Linux-only Python discovery behavior in the new isolated-environment test (
sys.executablewas empty afterenv_clear). The grandchild now uses the samepython3lookup as its parent. All 9 Registry scenario tests passed locally; a Linux subprocess probe reproduced the old failure and passed with the new lookup while preserving telemetry opt-out, OTel, and the provider sentinel.Public and local-development defaults
Remove the forced telemetry opt-out from the root public
worker-compose.yaml; it now matches the original public development configuration. Team members explicitly exportIII_TELEMETRY_ENABLED=falsebefore local development. CI, campaign runners, and isolated scenario/test environments retain explicit opt-outs. Public defaults and OpenTelemetry settings are preserved.Fresh verification: 48 Python telemetry/campaign tests plus 24 subtests passed. The public Compose file is byte-identical to the base branch; whitespace checks passed. No Rust source changed in this follow-up.
Related PRs
Coordinated internal telemetry opt-out changes:
Rollout: deploy Registry #107 before releasing III #2172. The other repository workflow/launcher changes can be integrated independently; full nested runtime propagation requires the updated III release. No merge or deployment is included in this PR publication.