Skip to content

fix(telemetry): opt out isolated test stacks and subject processes - #131

Open
ytallo wants to merge 3 commits into
mainfrom
fix/internal-telemetry-opt-out
Open

ytallo wants to merge 3 commits into
mainfrom
fix/internal-telemetry-opt-out

Conversation

@ytallo

@ytallo ytallo commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Pin III_TELEMETRY_ENABLED=false in CI, campaign/supervisor launchers, generated Compose/Docker environments, and subject execution boundaries. Apply it after caller environment merges and restore it across cleared environments, bubblewrap, and Docker execution while preserving provider secret allowlists and OpenTelemetry settings.

Validation completed locally before publication: Rust all-target tests passed (716 passed, 1 ignored), the combined Python selection passed (167/167), fixture lifecycle tests passed (14), and a real Docker probe/grandchild both observed the opt-out despite an enabled parent. Formatting and syntax checks passed.

Rust validation used a canonical TMPDIR for an existing macOS cleanup-path mismatch. Full exact-stack/LLM, supervisor, and Linux bubblewrap runtime validation was not run; the supervisor's existing reference to missing scripts/release_control_campaign.py is outside this change.

Publication follow-up: CI exposed Linux-only Python discovery behavior in the new isolated-environment test (sys.executable was empty after env_clear). The grandchild now uses the same python3 lookup as its parent. All 9 Registry scenario tests passed locally; a Linux subprocess probe reproduced the old failure and passed with the new lookup while preserving telemetry opt-out, OTel, and the provider sentinel.

Public and local-development defaults

Remove the forced telemetry opt-out from the root public worker-compose.yaml; it now matches the original public development configuration. Team members explicitly export III_TELEMETRY_ENABLED=false before local development. CI, campaign runners, and isolated scenario/test environments retain explicit opt-outs. Public defaults and OpenTelemetry settings are preserved.

Fresh verification: 48 Python telemetry/campaign tests plus 24 subtests passed. The public Compose file is byte-identical to the base branch; whitespace checks passed. No Rust source changed in this follow-up.

Related PRs

Coordinated internal telemetry opt-out changes:

Rollout: deploy Registry #107 before releasing III #2172. The other repository workflow/launcher changes can be integrated independently; full nested runtime propagation requires the updated III release. No merge or deployment is included in this PR publication.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 489a26cf-e6c9-42b2-96c2-3755c16d1f86


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant