Handling no received data from WeatherSource#1145
Open
PhilippSchmelter wants to merge 99 commits intodevfrom
Open
Handling no received data from WeatherSource#1145PhilippSchmelter wants to merge 99 commits intodevfrom
PhilippSchmelter wants to merge 99 commits intodevfrom
Conversation
This reverts commit 529bf23
…d changed NoDataException
Contributor
Author
|
Handling CSV-Source done
|
danielfeismann
requested changes
Mar 17, 2026
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Thanks for including the steps for possible healing of missing data. I have some additions and questions.
Member
danielfeismann
left a comment
danielfeismann
left a comment
There was a problem hiding this comment.
Thanks for considering the discussed points. This looks good to me! However, since weather is very important within our simulations I would prefer to have also a look by @staudtMarius on this.
staudtMarius
requested changes
Mar 23, 2026
Member
staudtMarius
left a comment
staudtMarius
left a comment
There was a problem hiding this comment.
Here are some first remarks from my side.
danielfeismann
added
enhancement
# Conflicts: # src/test/groovy/edu/ie3/datamodel/io/source/couchbase/CouchbaseWeatherSourceCosmoIT.groovy # src/test/groovy/edu/ie3/datamodel/io/source/couchbase/CouchbaseWeatherSourceIconIT.groovy
staudtMarius
requested changes
Apr 10, 2026
Member
staudtMarius
left a comment
staudtMarius
left a comment
There was a problem hiding this comment.
Some remarks from my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #554
Added an explicit Exception for handling no received data from WeatherSource to prevent the pipeline moving on without data.