Name saved desktop servers, hide This Mac, and switch servers from the palette

[idrevnii]

Human comments

What was wrong

Window → Server names saved servers only by host (10.0.0.3:38886) and always lists This Mac. The rendered app cannot reach that list at all: BbDesktopApi exposes no server targets (get-bb#3133). That works for one extra server. It breaks down for people who deliberately run several independent bb instances, each with its own users, projects, and plugins, and switch between them in one desktop app; for example a personal server, one shared with a friend, and a homelab "ops" server. Those instances are separate on purpose, so moving them onto machines of a single server (the reason get-bb#628 gave for removing the earlier multi-server UI from get-bb#605) is not a substitute. Separately, server-target.json is parsed with a strict schema: a file containing any field the running build does not know loads as "no saved servers", and the next save (for example Add Server…) overwrites it. Moving between desktop builds, in either direction, can therefore silently erase the saved list.

What changed

This keeps server targeting in the native menu, the direction set by get-bb#628 and get-bb#3919, and adds no renderer management UI.

Desktop shell (apps/desktop):

• server-url-dialog*.ts: the existing Add Server… and Set Server URL… dialogs get an optional Name field, using the same markup and CSS as the URL field.
  • The name replaces the host in the menu.
  • Adding an already-saved URL with a name renames it; with no name, the saved name is kept.
• server-target.ts:
  • Set Server URL… now edits the server in place, keeping its position and name instead of moving it to the end. Clearing the URL still removes the server.
  • Names (keyed by URL) and the new This Mac choice are stored in a separate server-menu.json. server-target.json keeps exactly the format released builds write, so older and newer builds read each other's files.
  • Unknown fields are now ignored instead of invalidating the file. A missing or corrupt server-menu.json only resets names and the This Mac choice.
• menu.ts, server-list.ts:
  • A Show This Mac checkbox at the bottom of the Server menu.
  • This Mac stays listed while it is the current server or when no other server is saved, so hiding it can never leave the menu empty.
• preload.ts, packages/desktop-contract/src/servers.ts: optional getServerTargets, onServerTargetsChange, and selectServerTarget members on BbDesktopApi, as Expose the Desktop server selector in the sidebar header get-bb/bb#3133 proposes.
  • They carry names and opaque ids (a hash of the URL), never URLs.
  • Selection is accepted only from application-window main frames, must match a listed id, and runs through the same setActiveServerTarget path as the menu.

App (apps/app):

• The quick palette offers Switch to server: <name> for every other listed server (palette-server-actions.ts, useDesktopServerTargets.ts).

Other surfaces:

• Docs: apps/desktop/README.md (Saved servers) and the verify-bb desktop recipe.
• Wire and APIs: no server/daemon wire change, so no HOST_DAEMON_PROTOCOL_VERSION bump. No plugin API change.
• CLI: no CLI command. The saved-server list and menu are local to the desktop shell (as with dataDirectory.open in Add a quick palette command to open the data directory get-bb/bb#4256), and the CLI already targets any server through BB_SERVER_URL.

Deviation from get-bb#3133: it asks for a sidebar selector. This PR adds the bridge it describes but switches from the quick palette only, keeping app chrome unchanged; a sidebar control could build on the same members. Related: get-bb#1451 (multiple desktop servers). The This Mac checkbox also covers the "hide This Mac from the Server menu" part of get-bb#3168, though not its request to stop starting the bundled runtime.

Palette entries need both a desktop build and a served app that include this change; older desktops simply omit the optional bridge members.

How you verified

• pnpm exec turbo run typecheck lint --filter=@bb/app --filter=@bb/desktop --filter=@bb/desktop-contract
• pnpm exec turbo run test --filter=@bb/desktop --filter=@bb/desktop-contract: 444 + 22 passed, 1 skipped (existing).
• pnpm exec turbo run test --filter=@bb/app: 5076 passed, 5 skipped (existing).
• The data loss described above was confirmed against main's server-target.ts with a real file:
  • a file with two saved servers plus one unknown field loaded as [] / builtin;
  • after Add Server… the file held only the new server.
• New and updated tests:
  • server-target.test.ts:
    • naming;
    • keeping a name across reselection;
    • in-place URL edits and clearing a name;
    • rejecting an over-long name without writing either file;
    • reload persistence;
    • the written server-target.json passes a copy of the released strict schema;
    • a file with unknown fields (including one written by an earlier build of this branch) keeps all saved servers and the target;
    • a corrupt server-menu.json leaves the server list intact.
  • server-list.test.ts: names and hosts, This Mac visibility rules, opaque ids.
  • menu.test.ts: the Show This Mac checkbox.
  • palette-server-actions.test.ts and CommandPalette.test.tsx: switching from the palette.
• Manual check on Linux: source-built Electron with an isolated profile against pnpm start:worktree, with two saved servers pointing at it through 127.0.0.1 and localhost, driven through CDP.
  • Set Server URL opened with the URL and name filled in, and renaming updated the menu.
  • Add Server with an existing URL and a name renamed that server and switched to it.
  • Unchecking Show This Mac removed it from the menu and the bridge.
  • The palette listed the other server, and selecting it loaded that server.
• Not verified: physical macOS; menu behavior there is unchanged Electron menu code.

Refs get-bb#3133, get-bb#1451, get-bb#3168

🤖 Generated with Claude Code

AGENT GENERATED

[idrevnii]

Superseded by get-bb#4296.