feat: restyle and sort meeting cards#526
Conversation
Windslash123
changed the title
* chore: 🔧 pull notifs into page * chore: 🔧 create mobile notif drawer * chore: 🔧 hook notifs up into groups and meetings * chore: 🔧 hook meetings up to notifs * chore: 🔧 add select all / mark as read functions * chore: 🔧 use styled components, remove sx * fix: 🐛 only render finished message when no unreads * chore: 🔧 only render mark as read when notifs are selected * fix: 🐛 merge conflict typo * fix: 🐛 duplicate groups headers, add indicator for notifs * fix: 🐛 realign headers * chore: 🔧 switch from iconbutton to MUI button (remove boxshadow) * refactor: ♻️ pull out notif utils/actions * refactor: ♻️ use inline sx and use MUIBottomSheet * style: 🎨 buttons --------- Co-authored-by: Arshia Aravinthan <aravinta@uci.edu> Co-authored-by: ethancha0 <ethanchao2005@gmail.com>
* fix: 🐛 non-admins can now invite members to meetings on desktop * fix: 🐛 verify that user is a meeting member or host before allowing them to invite others * feat: ✨ hosts can toggle whether members are allowed to invite others to a meeting * fix: 🐛 updated earlier membership check logic for inviting members * fix: 🐛 disable toggle while invite permissions are being updated in the DB * feat: ✨ revalidatePath, consolidated types --------- Co-authored-by: ethancha0 <ethanchao2005@gmail.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 8 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
2 issues found across 5 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
ethancha0
left a comment
ethancha0
left a comment
There was a problem hiding this comment.
Hey Arshia, the code looks great! I just pushed a change that consolidates some code into a .utils.ts file.
I did notice an edge case where the meeting card still requests availability when the user has only inputted "if-needed" blocks.
Other than this, should be ready to merge! Thanks you for your continued hard work with this and the many other PRs you've been working on!
Screen.Recording.2026-05-19.at.8.21.29.PM.mov |
|
note: the meeting card properly detects if a user has filled availability if at least one availabe block is detected. the video above didn't really capture it well when i went back to the prvious page. (it was fine when i refreshed page). perhaps an added revalidate path (/summary) would solve this lmk if this was confusing |
|
@ethancha0 The changes you pushed for the card styling moved the drop shadow to the bottom of the banner instead the bottom of the card (per the Figma). Was this intentional? Current: Figma: |
oops was not intentional |
ethancha0
force-pushed
the
aa/style-and-sort-meeting-cards
branch
from
ac8762e to
dd8796f
Compare
3 participants
Description
upcomingandpastfilters, upcoming is default instead ofallnowRecording/Screenshots
Screen.Recording.2026-05-19.at.5.37.21.PM.mov
Test Plan
Issues