-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Decompile C# 15 runtime-async (/features:runtime-async=on)
#3731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
siegfriedpammer
wants to merge
12
commits into
icsharpcode:master
Choose a base branch
from
siegfriedpammer:runtime-async
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
102ffa7
Add tests
siegfriedpammer 5cc285d
Add scaffolding for the C# 15 runtime-async lowering.
siegfriedpammer dfc856b
Handle non-Task task-likes (ValueTask, custom AsyncMethodBuilder) in …
siegfriedpammer 208bf85
Reverse runtime-async lowering of try-finally and try-catch with await.
siegfriedpammer 24b01c5
Normalize runtime-async catch filters to recover catch-with-when.
siegfriedpammer 27dc959
Reduce multi-handler runtime-async try-catch back to a multi-handler …
siegfriedpammer 1acd63a
Reduce runtime-async manual await pattern (non-Task awaitables) to Aw…
siegfriedpammer 0c8bf9d
Convert AsyncHelpers.Await calls to the IL Await instruction.
siegfriedpammer 1c41c84
Force portable PDB output for runtime-async test compiles.
siegfriedpammer 8812f78
Accept any branch as the runtime-async try-finally exit target.
siegfriedpammer c93c34a
Recover the this-copy that runtime-async inserts at the entry of stru…
siegfriedpammer 84c2d07
Reverse runtime-async flag-based early-return across a try-finally.
siegfriedpammer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -121,7 +121,11 @@ public void Run(ILFunction function, ILTransformContext context) | |
| awaitDebugInfos.Clear(); | ||
| moveNextLeaves.Clear(); | ||
| if (!MatchTaskCreationPattern(function) && !MatchAsyncEnumeratorCreationPattern(function)) | ||
| { | ||
| if (function.Method?.IsAsync == true) | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this needs a decompiler settings check, should only run if Runtime Async is enabled. |
||
| RuntimeAsyncExceptionRewriteTransform.Run(function, context); | ||
| return; | ||
| } | ||
| try | ||
| { | ||
| AnalyzeMoveNext(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christophwille I think you found out, that this is no longer needed?