Skip to content

add first draft of non-modularized code#11

Merged
hhollandmoritz merged 12 commits intodevelopmentfrom
code
Apr 6, 2026
Merged

add first draft of non-modularized code#11
hhollandmoritz merged 12 commits intodevelopmentfrom
code

Conversation

@JessicaS11
Copy link
Copy Markdown
Member

@JessicaS11 JessicaS11 commented Mar 19, 2026

Adds the first draft of the code to the repo. This code is still under heavy development and will be undergoing a complete restructuring in the coming weeks to make it more modular (e.g. class-based architecture) and include an optional JupyterNotebook to run it step-by-step rather than as a single pipeline (current functionality to run it as a Python script from the command line will remain).

@JessicaS11 JessicaS11 marked this pull request as ready for review March 19, 2026 16:30
@JessicaS11 JessicaS11 marked this pull request as draft March 19, 2026 16:33
@JessicaS11 JessicaS11 changed the title add some basic code infrastructure pieces add first draft of non-modularized code Mar 19, 2026
@JessicaS11 JessicaS11 marked this pull request as ready for review March 31, 2026 19:34
@JessicaS11
Copy link
Copy Markdown
Member Author

The pre-commit and linter checks are (in my opinion) not worth fixing for this PR given that the code will change substantially, so we can implement these "best practice" habits as we go. I suspect we'll also run into the same sort of thing eventually with the typecheck (because there is no typing - where we specify that a given function outputs, for instance, a list of strings). But @hhollandmoritz, if it's a quick fix to get it to at least pip install, that would be super! If it's more than a quick fix or something you're not wanting to dive into, then we should just go ahead and get this merged as a starting point so you can start making the more critical changes.

…s in dynamic dependencies should be specified via the requirements.txt file; and fallback version of aok now set to 0.0.0
@hhollandmoritz
Copy link
Copy Markdown
Contributor

@JessicaS11 Well I don't know if it's "kosher" or not, but I was able to get it to install by changing the fallback version in the pyproject.toml file from "unkown" to "0.0.0" (since apparently "unknown" is not allowed). And by setting the dynamic dependencies to use the requirements.txt file rather than what was previously there ("numpy"). Again, not sure if this is how we plan to specify the dependencies longer-term, but python -m pip install . runs now.

And when I ran main.py it was able to load all the modules and crash out on the config file loading (because I didn't bother to change the file paths).

(Whether it works as expected, beyond that, I have no idea), but that seems like a good starting place to me.

I think we can merge.

@hhollandmoritz hhollandmoritz self-requested a review April 6, 2026 13:57
Copy link
Copy Markdown
Contributor

@hhollandmoritz hhollandmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @JessicaS11 stated the linter and ghactions are not worth fixing at this time. Pip install works, I am self-approving this merge.

@hhollandmoritz hhollandmoritz merged commit 81c21d3 into development Apr 6, 2026
0 of 3 checks passed
@hhollandmoritz hhollandmoritz deleted the code branch April 6, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants