feat: GNOME Shell 50 compatibility, overview signals, and QA tooling#156
Open
ondrovic wants to merge 2 commits into
Open
feat: GNOME Shell 50 compatibility, overview signals, and QA tooling#156ondrovic wants to merge 2 commits into
ondrovic wants to merge 2 commits into
Conversation
Align Search Light with GNOME Shell 48–50 by connecting to Main.overview's real showing/hidden signals instead of overview-showing/overview-hidden, so _inOverview tracks the overview correctly. Replace the brittlesearch-results grid walk in _isDraggingIcon with a recursive lookup for grid-search-results and defensive drag checks. Drop unused Graphene wiring and fix metadata to use settings-schema for current Extension APIs. Refresh the README for install, session restart, shortcuts, and blurdependencies. Add make test (strict schemas + ESLint via npx), relax ESLint for this codebase's style, and fall back to Python when zip is missing for publish. Bump extension version to 102. Also apply small lint-driven fixes across prefs, keybinding, effects, shortcuts, style, timer, and easing (including a runAnimation array check).
Contributor
|
Hi @icedman, can you help to review and merge this PR? hope its can be merged and updated to gnome extension as soon as possible |
|
Fwiw, tested this on GNOME 50, and it seems to work. |
|
I have tested the files in this PR with the latest Fedora 44: search-light extension works perfectly on GNOME 50 with these updated files. |
|
Is this project abandoned? |
|
@icedman hey, could you check and merge this ? its been a while after this is opened. |
|
FYI: the plugin is already compatible but the review on the GNOME extension portal is missing, see also #155 (comment). The PR title was a bit misleading to me so I wanted to provide that information to others that @icedman did already provide GNOME 50 compatibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align Search Light with GNOME Shell 48–50 by connecting to Main.overview's real showing/hidden signals instead of overview-showing/overview-hidden, so _inOverview tracks the overview correctly. Replace the brittlesearch-results grid walk in _isDraggingIcon with a recursive lookup for grid-search-results and defensive drag checks. Drop unused Graphene wiring and fix metadata to use settings-schema for current Extension APIs.
Refresh the README for install, session restart, shortcuts, and blurdependencies. Add make test (strict schemas + ESLint via npx), relax ESLint for this codebase's style, and fall back to Python when zip is missing for publish. Bump extension version to 102.
Also apply small lint-driven fixes across prefs, keybinding, effects, shortcuts, style, timer, and easing (including a runAnimation array check).