Skip to content

Conversation

@hrishipathak
Copy link

Added a recipe (python notebook) for Generating RAG Code.

Signed-off-by: hrishipathak <[email protected]>
Signed-off-by: hrishipathak <[email protected]>
Copy link
Contributor

@rawkintrevo rawkintrevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase on main and recipes/Generate_RAG_Code/Generate_RAG_Code.ipynb
to the appropriate file in .github/workflows

Also to the same file in .github/notebook_lists.

@rawkintrevo
Copy link
Contributor

Thanks for the contribution @hrishipathak - delete the empty file (assuming it was created by accident) and clear your outputs, and add to the workflows per my last comment and I think you'll be good to merge

@hrishipathak
Copy link
Author

Hi Trevor @rawkintrevo

Thanks for your review and comments. I've completed the following changes:-

  1. Deleted the empty file (.gitkeep)
  2. Notebook outputs cleared
  3. Added recipes/Generate_RAG_Code/Generate_RAG_Code.ipynb to .github/workflows/vanilla_workflow.yaml
  4. Added recipes/Generate_RAG_Code/Generate_RAG_Code.ipynb to .github/notebook_lists/vanilla_notebooks.txt
  5. Modified the code as per latest ibm-granite-community/granite-kitchen package

Please review and let me know if any more changes are required. Thank you.

@hrishipathak hrishipathak removed the request for review from muthukumaran25 October 15, 2024 20:08
Signed-off-by: hrishipathak <[email protected]>
@hrishipathak hrishipathak self-assigned this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants