Merged
Conversation
Added `message` option to override the default validation message.
Member
|
@lowerends Thanks! Can you make tests pass and pass |
Contributor
Author
|
@dannyvankooten Do you need anything else from my side at this moment? Happy to help! |
Member
|
@lowerends If you could make tests pass then I can merge this. There is one test failing after your change: You can confirm by running |
Contributor
Author
|
@dannyvankooten Ok, I fixed the test as well now. |
Contributor
Author
|
Hi @dannyvankooten, do you need anyting from my side to merge this in? If so, let me know :) |
Member
|
@lowerends Just tagged 2.3.0. Sorry, needed to check a few things now that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
messageoption to override the default validation message.