Skip to content

docs: add code-audit improvement suggestions - #27

Draft
i11v wants to merge 1 commit into
mainfrom
claude/code-audit-suggestions-5ilnk8
Draft

docs: add code-audit improvement suggestions#27
i11v wants to merge 1 commit into
mainfrom
claude/code-audit-suggestions-5ilnk8

Conversation

@i11v

@i11v i11v commented Jul 11, 2026

Copy link
Copy Markdown
Owner

What

Adds docs/IMPROVEMENTS.md — a full code audit of the repo with 33 verified findings, written so each suggestion is a self-contained task (problem statement, quoted code, concrete fix sketch, acceptance criteria, effort estimate) that can be picked up and implemented independently, including by a smaller model.

Scope of the audit

  • packages/worker (8 findings: WKR-01…08) — Durable Objects, gateway caching, Golemio client
  • packages/web (13 findings: WEB-01…13) — React app, WS hook, URL/state handling, accessibility
  • Contract, scripts, CI, tooling (12 findings: TLG-01…12) — stop-index build, GTFS caching, workflows, lefthook

Every claim was verified against the actual code (and where relevant, by executing the code in question); a closing section lists things that were examined and deliberately not flagged, to save future auditors time.

Highlights (fix-first list)

  • WEB-01 — selecting a whole multi-name stop force-pins one platform and silently hides the other platforms' departures
  • WEB-02 — a hand-edited ?s= URL bypasses the wire-protocol caps and wedges the WebSocket feed
  • TLG-01 — a NaN coordinate passes the build-time schema check but serializes to null, shipping a client-breaking stop index through green CI
  • WKR-01 — an integration test asserts 400 where the worker now returns 426, unnoticed because test:integration isn't wired into CI
  • WKR-02 — ClientSession DO storage leaks (retained and billed indefinitely) when a socket disconnects without a close frame
  • TLG-03 — a corrupt-but-200 GTFS download overwrites the last-good cache before validation, defeating the outage fallback

Baseline at audit time: typecheck, lint, and all 82 unit tests green.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WgpPdTSGKeydeG9Xqb8Sqv


Generated by Claude Code

33 audited findings across worker, web, and tooling/CI, each written
as a self-contained task (problem, quoted code, concrete fix,
acceptance criteria) so any suggestion can be picked up and
implemented independently.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WgpPdTSGKeydeG9Xqb8Sqv
@i11v
i11v force-pushed the claude/code-audit-suggestions-5ilnk8 branch from 62eb710 to 6f22b97 Compare July 13, 2026 19:51
@github-actions

Copy link
Copy Markdown

🚀 Preview deployed: https://preview-27.tablo.run
fallback: https://tablo-pr-27.i11v.workers.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants