Repository navigation
test(integration): keep lifecycle negative checks in the echo suite - #1062
Merged
mbrandenburger merged 1 commit intoNov 5, 2026
Merged
mbrandenburger merged 1 commit into
mbrandenburger merged 1 commit into
Conversation
echo_test.sh now checks both plugin variants (-E mock-escc, and -E mock-escc -V fpc-vscc) of approveformyorg, checkcommitreadiness and commit, plus the two initEnclave checks. auction_test.sh had the only other copy of an approveformyorg check, now covered by echo; it keeps its positive lifecycle steps. deployment_test.sh is unchanged: its checks are part of its mixed FPC and non-FPC scenario. Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
munapower
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The C++ suites repeat the peer lifecycle negative checks:
try_failcalls that pass an endorsement or validation plugin toapproveformyorg,checkcommitreadinessandcommit, which FPC rejects. These test the peer lifecycle wrapper, not the chaincode, so one suite is enough. This PR puts all of them inecho_test.sh:echo_test.shgains the-E mock-escc -V fpc-vsccvariant of all three subcommands, next to the-E mock-esccone it already had. Before this PR, the-V fpc-vsccvariant ofcheckcommitreadinessandcommitwas only tested indeployment_test.sh.auction_test.shdrops its onetry_fail(approveformyorg -E mock-escc -V fpc-vscc). It keeps its positive lifecycle steps.deployment_test.shstays as it is. It runs two FPC chaincodes and a non-FPC one on the same peer, and itstry_faillines are part of that setup.kv_test.shhad none.Chaincode checks (
try_out_r … check_result) stay where they are: they test the chaincode, and each C++ suite tests a different one.auction_test.sh:37approveformyorg -E mock-escc -V fpc-vsccecho_test.sh:37(same subcommand and flags), anddeployment_test.sh:92After this PR, the
try_faillines (lines insgx/integration/, common flags left out):echo:36,echo:37approveformyorg-E mock-escc;-E mock-escc -V fpc-vsccecho:41,echo:42checkcommitreadiness-E mock-escc;-E mock-escc -V fpc-vsccecho:46,echo:47commit-E mock-escc;-E mock-escc -V fpc-vsccecho:51initEnclave --name wrong-cc-idecho:55initEnclave(second call on an initialized enclave)deployment:92,96,100,104-E mock-escc -V fpc-vscc, andinitEnclave --name wrong-cc-idWhich issue(s) this PR fixes:
Fixes #1042. Part of #1044.
Special notes for your reviewer:
test (echo)log, each newtry_failshould fail because the plugin is rejected, not because of a CLI usage error. I'll check this once CI has run and add the log lines here.-E mock-esccsibling and before thetrythat succeeds, so it runs while the chaincode is still unapproved and uncommitted, the same state the sibling runs in.