SV UI Integration tests - Offboard SV #3306
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fayi-da
commented
Dec 1, 2025
| new FirefoxOptions() | ||
| .setLogLevel(FirefoxDriverLogLevel.DEBUG) | ||
| .addArguments("-headless") | ||
| // .addArguments("-headless") |
Contributor
Author
There was a problem hiding this comment.
Use this to disable headless mode. I find it easier to understand issues as I can see what the test is doing
fayi-da
commented
Dec 1, 2025
| // We process all browsers in parallel, for faster test termination. | ||
| webDrivers.values.toList.parTraverse { webDriver => | ||
| Future { | ||
| com.digitalasset.canton.concurrent.Threading.sleep(30000) |
Contributor
Author
There was a problem hiding this comment.
Keeps the browser open for 30secs after the test. Sometimes i want to inspect elements or see console errors, e.t.c. Remember to not merge these of course :)
fayi-da
commented
Dec 1, 2025
| } | ||
| } | ||
|
|
||
| "NEW UI: Offboard" in { implicit env => |
Contributor
Author
There was a problem hiding this comment.
Rename this test of course :)
fayi-da
commented
Dec 1, 2025
| "NEW UI: Offboard" in { implicit env => | ||
| val sv3PartyId = sv3Backend.getDsoInfo().svParty.toProtoPrimitive | ||
|
|
||
| createProposal("SRARC_OffboardSv") { implicit webDriver => |
Contributor
Author
There was a problem hiding this comment.
Once createProposal() works, it should be pretty easy to complete the tests for the other proposals since they all use createProposal.
Signed-off-by: fayi-da <[email protected]>
fayi-da
force-pushed
the
fayi/3219-offboard-integration-test
branch
from
f0d7c66 to
2934430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines