Unify minimum/maximum error handlers with draft-04 compatibility#163
Open
Padmashree06 wants to merge 1 commit intohyperjump-io:mainfrom
Open
Unify minimum/maximum error handlers with draft-04 compatibility#163Padmashree06 wants to merge 1 commit intohyperjump-io:mainfrom
Padmashree06 wants to merge 1 commit intohyperjump-io:mainfrom
Conversation
jdesrosiers
requested changes
Feb 10, 2026
Collaborator
jdesrosiers
left a comment
There was a problem hiding this comment.
The new error handlers look like the right idea, but there's a lot of cleanup that needs to be done everywhere else.
- You need to rebase your branch and resolve conflicts
- The old handlers need to be removed
- There's no need for new normalization handlers
- There should be no changes to
hyperjump-json-schema.test.js
Contributor
Author
|
Thank you for the feedback. Regarding the changes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces unified error handlers for:
minimum,exclusiveMinimumanddraft-04 minimummaximum,exclusiveMaximumanddraft-04 maximumThe handlers now select and report only the most restrictive constraint, producing a single validation error instead of multiple overlapping messages.
Additional Updates
index.jsto avoid overlap and can be removed if preferred.Tests
All tests pass locally.
Fixes
Issue: #135