Repository navigation
fix(http2): keep connection open after rejecting CONNECT - #4235
Merged
seanmonstar merged 1 commit intoNov 13, 2026
Merged
Conversation
Continue accepting streams after resetting a CONNECT request with a nonzero Content-Length. Returning from the server loop closes the entire HTTP/2 connection and interrupts unrelated requests. Add a regression test that keeps a GET in flight during the reset and then sends another GET over the same connection.
shuvroroy
marked this pull request as ready for review
October 18, 2026 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CONNECT request with nonzero
Content-Lengthcurrently resets its stream and then exits the HTTP/2 server loop. That closes the entire connection and interrupts unrelated requests.Continue accepting streams after sending the existing
INTERNAL_ERRORreset. The regression test holds a GET open while CONNECT is rejected, verifies the reset, and checks that both the pending GET and a subsequent GET complete on the same connection.Validation:
cargo test --features full: 329 passed, 10 ignored.cargo clippy --features full -- -D warnings: passed.rustfmt --check --edition 2021: passed.cargo check --no-default-features --features server,http2: passed.This draft description was generated with AI assistance. The human-authorship checkbox remains unchecked pending a human rewrite.