fix(client): map Delete key to erase selection#308
Open
fuleinist wants to merge 1 commit intohundredrabbits:mainfrom
Open
fix(client): map Delete key to erase selection#308fuleinist wants to merge 1 commit intohundredrabbits:mainfrom
fuleinist wants to merge 1 commit intohundredrabbits:mainfrom
Conversation
The Delete key was reported not working for erasing selections, while Backspace worked correctly. On Windows, users muscle-memory expects Delete to erase. Interestingly, Shift+Delete already worked as cut. This change adds 'Delete' as a second accelerator for the same erase action, mirroring the Backspace behavior. No new behavior is introduced; Delete now behaves identically to Backspace when erasing. Fixes hundredrabbits#280
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Delete key now erases selections in Orca, matching the behavior of Backspace. This fixes issue #280 where users on Windows expected Delete to work like Backspace for erasing.
Problem
On Windows (version 247, downloaded from itch), the Delete key did not erase selections while Backspace did. Interestingly Shift+Delete already worked as cut. This was a gap in keyboard support for editing operations.
Solution
Added Delete as a second accelerator for the same erase action in client.js. The fix reuses the exact same handler as Backspace.
Testing
Files Changed
Fixes #280