Tests: separate consumer archive checks - #97
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The default repository suite performed two clean consumer/archive builds on every Node version. Those checks are valuable, but they are a separate environment and cost boundary from the deterministic repository tests. Closes #92.
Solution
The two archive builders now run once in a serial
test:consumersuite. The default suite excludes only those files; CI’s package-boundary job and the full release matrix explicitly run the consumer suite so its assertions remain release-blocking.Diff
+114 −153 · 9 files · no assertions removedTesting & verification
Reviewed revision:
768ecf4· local Nodev22.23.1· npm10.9.8npm run test:consumer— 2 files / 2 tests passed in 31.93s.npm run typecheck— passed in 2.876s.node --import tsx scripts/authoring-hashes.ts --check— passed in 0.260s.git diff --check— passed.The CI matrix is the compatibility gate for this split. A clean local Node 22.23 install hit an unrelated existing
wesper@0.0.3→zod/v4ESM-resolution failure instyles.test.ts; it is outside this PR’s files and is not presented as a passing default-suite result.Risk / rollout
The moved archive checks retain their original 300-second per-test allowance and serial execution. CI and the full release matrix fail if the consumer route fails; reverting this commit restores the former default-suite placement.