Use memmove for update_contact demunging to fix RISC-V test failure#501
Open
felixonmars wants to merge 1 commit into
Open
Use memmove for update_contact demunging to fix RISC-V test failure#501felixonmars wants to merge 1 commit into
felixonmars wants to merge 1 commit into
Conversation
g_strlcpy() with overlapping buffers is undefined behavior and causes the as-self-test to fail on RISC-V, where the optimized memcpy does not handle the overlap: "richard_at_hughsie_dot_co_dot_uk" -> "richard@hugh_ie.cot_ut_uk" Use memmove() instead which handles overlapping regions correctly.
felixonmars
added a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Mar 5, 2026
felixonmars
added a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Mar 5, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
g_strlcpy() with overlapping buffers is undefined behavior and causes the as-self-test to fail on RISC-V, where the optimized memcpy does not handle the overlap:
"richard_at_hughsie_dot_co_dot_uk" -> "richard@hugh_ie.cot_ut_uk"
Use memmove() instead which handles overlapping regions correctly.