Mute chatty xet in migration service #594
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo scanner migration services calls
xet-core/data/src/migration_tool/migrate.rs
Line 29 in 23f691b
INFOlevel. As a result, xet-core has been too chatty for repo scanner because we log atINFOlevel at many places because we wanted to log more info in hf-xet.This PR employs a build feature
elevated_information_levelwhich is enabled only for hf-xet, such that the information we want to log in hf-xet are still emitted atINFOlevel, but for others emitted atDEBUGlevel, so not to clutter the repo scanner log. It's not viable to pass in atracing::Levelvariable to use atevent!()because the macro expects a constant level value.Log size of a test that uploads a 10 MB file:
With migrate_with_external_runtime:
With hf-xet: