Skip to content

Support Marshmallow 3#926

Open
stefanor wants to merge 4 commits intohugapi:developfrom
stefanor:marshmallow3
Open

Support Marshmallow 3#926
stefanor wants to merge 4 commits intohugapi:developfrom
stefanor:marshmallow3

Conversation

@stefanor
Copy link
Copy Markdown

I'm unsure about 3d3591f, but the rest seems pretty straightforward:

  1. Take kwargs in post-processors, as marshmallow expects. They've added new named arguments, over time.
  2. Handle ValueError in validation.
  3. Set a default value for context in MarshmallowInputSchema. This is the bit I'm unsure of.
  4. Bump marshmallow deps in tox.

Fixes: #859

This is expected by upstream, and they have added arguments in newer
releases.

Fixes: hugapi#859
This is a lazy fix to a test, without fully understanding the codebase.
It looks like context *should* be provided when needed, I'm not quite
sure why it isn't being.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some tests fail

1 participant