docs: clarify why graceful shutdown is needed on Node.js but not Bun, Deno and others. - #899
Open
daniel-dia wants to merge 1 commit into
Open
Conversation
…not Bun/Deno Adds a two-sentence note explaining that @hono/node-server wraps Node's http module (which predates the Fetch API), which is why the server instance must be closed manually here, unlike on Bun/Deno where the runtime natively implements Fetch and owns the server lifecycle.
daniel-dia
marked this pull request as ready for review
August 20, 2026 03:30
daniel-dia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Node.js getting-started guide shows how to gracefully shut down the server, but doesn't say why this is only needed there and not on the Bun or Deno pages. This adds a short, two-sentence note explaining the reason:
httpmodule predates the Fetch API, so@hono/node-serverwraps it and exposes the resulting server instance for you to manage.Test plan
Opening as a draft while I get feedback on wording/placement.