fix: type error in early hints and add typecheck to CI - #390
Merged
Conversation
BlankParticle
force-pushed
the
fix/add-typecheck
branch
from
August 14, 2026 12:31
972fbe6 to
53cc2ae
Compare
Member
|
@BlankParticle Thanks! Btw, I added the autofix.ci action #392 |
BlankParticle
force-pushed
the
fix/add-typecheck
branch
from
August 15, 2026 06:43
53cc2ae to
d5d45f8
Compare
Contributor
Author
|
I have fixed the formatting issue and rebased 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a type error in
early-hints.ts, looks like we don't have a typecheck command nor we run typecheck in CI.I fixed the type error and added typecheck command and run it on CI for PRs