Simplify releases with generated build artifacts and one retained tarball - #20
Open
justjam2013 wants to merge 6 commits into
Open
justjam2013 wants to merge 6 commits into
justjam2013 wants to merge 6 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
binding.jsis now an ignored build/package artifact, generated automatically alongside every native prebuild. Version PRs update only authoritative version sources; no committed loader can become stale.Changes
npm run prepare-version -- 1.0.1updates package.json, both root package-lock.json versions, Cargo.toml, and the root Cargo.lock package. It requires only Node and does not build, stage, commit, tag, or publish.npm ci,npm run build, thennpm testandnpm run test:release. Every build generates the loader and host binary with pinned napi-rs and locked Cargo dependencies. Rebuild after source/version changes; never edit or commit binding.js.node scripts/assemble.jswith all eight same-commit artifacts.Preserved safeguards
Eight native builds and 24 retained-tarball installs on Node 22/24/26; one tarball plus SHA-512; CJS/ESM/API, real ICMP, resource and actual-libc tests; Trusted Publishing/OIDC/provenance/public access; npm-production; latest/next policy; non-cancelling publication concurrency; absolute tarball path; at-most-once npm publish; bounded registry visibility retries. Publisher code and publish workflow are unchanged by the artifact-model update. No stale-file detection, repair, auto-commit, or version-triggered generation.
Validation
At
d2e2c44:npm run prepare-version -- 1.0.1without installed dependencies changes only the four version files. A subsequent normal build generates the 1.0.1 loader and passes all 5 API tests. The manifest version also overrides an unrelated inherited npm_new_version.No merge, npm publication, tag/release changes, or release workflow dispatch. Repository version remains 1.0.0.